[
https://issues.apache.org/jira/browse/TINKERPOP-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415516#comment-17415516
]
ASF GitHub Bot commented on TINKERPOP-2601:
-------------------------------------------
spmallette opened a new pull request #1474:
URL: https://github.com/apache/tinkerpop/pull/1474
https://issues.apache.org/jira/browse/TINKERPOP-2601
JVM based providers can now easily testing with the Gherkin feature tests
which were formerly just built for testing GLVs. The benefit here is that we no
longer need to do duplicate test writing (i.e. once in the old Process Test
Suite in Java and then again in Gherkin). For 3.6.0 I think the plan is to
maintain both suites but recommend providers implement the Gherkin version
along with the transitional new "limited" process suite. Ultimately, the idea
would be simple delete all tests from Java that already exist in Gherkin and to
migrate all provider oriented tests to Gherkin. The latter will likely require
some additional changes to both the test definitions and the various runners in
each programming language. I'd think that for 3.7.0 we could begin the process
of deleting the Java tests and not relying on them anymore.
Going forward, we should look to only write tests in Gherkin unless there is
some semantic that we currently can't express by way of the runner, though
other exceptions may exist and we don't need a hard and fast rule for that.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Unify Gremlin testing behind Gherkin
> ------------------------------------
>
> Key: TINKERPOP-2601
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2601
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.4.12
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
>
> We currently use Gherkin for testing GLVs, translators and the grammar. The
> final step is to get Gherkin tests acting as the primary tests in the Gremlin
> Test Suite itself so that they may be run on the JVM for providers.
> Initially, at least in 3.6.0, it makes sense to maintain the old tests where
> they are but the ultimate goal should be to deprecate and remove the process
> suite and make the structure suite optional. In this way we aren't too
> opinionated about how providers implement their graph and are only interested
> in enforcing Gremlin semantics
> Given improvements in {{null}} handling on TINKERPOP-2605 a lot of new
> gherkin tests are arriving. Need to add null annotations for graphs that can
> store null and include testing for such cases. This might be a separate
> issue, but for tying it to this one for now.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
