[ 
https://issues.apache.org/jira/browse/TINKERPOP-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Mallette closed TINKERPOP-2387.
---------------------------------------
    Resolution: Won't Do

After TINKERPOP-2601 this likely isn't a concern anymore as gherkin tags are 
grouping tests and allow for easier and explicit exclusion as needed. There is 
no more general exception based ignores.

> Test suite ignores more tests than it should for GraphComputer
> --------------------------------------------------------------
>
>                 Key: TINKERPOP-2387
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2387
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.4.7
>            Reporter: Stephen Mallette
>            Priority: Minor
>
> A lot of tests in the test suite will throw a {{VerificationException}} when 
> executed on {{GraphComputer}}. iirc, we did that globally in 
> {{GremlinProcessRunner}} to help avoid a lengthy ignore list in annotations. 
> The problem I'm seeing is that {{VerificationException}} can lead to false 
> negative and false positive results in tests which means we might never 
> really notice bugs because a test is ignored automatically when it shouldn't 
> be or we get test failures and don't really understand why (as no one every 
> remembers the little if/then logic tucked away in {{GremlinProcessRunner}}.
> This issue might need to fold under a general re-structuring of the test 
> suite behind our cucumber tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to