[
https://issues.apache.org/jira/browse/TINKERPOP-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456803#comment-17456803
]
ASF GitHub Bot commented on TINKERPOP-2555:
-------------------------------------------
lyndonb-bq commented on a change in pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515#discussion_r766213513
##########
File path:
gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py
##########
@@ -48,21 +67,25 @@ def __init__(self, url, traversal_source = "g",
protocol_factory=None,
password=password,
kerberized_service=kerberized_service,
headers=headers,
+ session=session,
**transport_kwargs)
self._url = self._client._url
self._traversal_source = self._client._traversal_source
def close(self):
+ logging.info("closing DriverRemoteConnection with url '%s'",
str(self._url))
self._client.close()
def submit(self, bytecode):
+ logging.debug("submit with bytecode '%s'", str(bytecode))
result_set = self._client.submit(bytecode,
request_options=self._extract_request_options(bytecode))
results = result_set.all().result()
return RemoteTraversal(iter(results))
- def submitAsync(self, bytecode):
+ def submit_async(self, bytecode):
Review comment:
Sounds good, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Support for remote transactions in Python
> -----------------------------------------
>
> Key: TINKERPOP-2555
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2555
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.5.0
> Reporter: Stephen Mallette
> Priority: Major
>
> TINKERPOP-2537 introduced remote transactions with {{g.tx()}} for use with
> Java. The same functionality should be made available in Python.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
