[
https://issues.apache.org/jira/browse/TINKERPOP-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503401#comment-17503401
]
ASF GitHub Bot commented on TINKERPOP-2716:
-------------------------------------------
jorgebay commented on pull request #1582:
URL: https://github.com/apache/tinkerpop/pull/1582#issuecomment-1062691147
Thanks for taking care of this!
I like prettier but given that is a codebase that's been around for
sometime, is hard to implement a strict set of rules.
I would remove prettier rules and include
[eslint:recommended](https://eslint.org/docs/rules/), with quotes: single and a
few more that you feel that would help to unify the codebase. fwiw I've used
these ones in the past on an old codebase:
https://github.com/datastax/nodejs-driver/blob/master/.eslintrc.js
Another thing to have in mind would be to only include rules which errors
can automatically be fixed (no manual changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Enable eslint for gremlin-javascript project
> --------------------------------------------
>
> Key: TINKERPOP-2716
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2716
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.5.2
> Reporter: Tom Kolanko
> Priority: Minor
>
> The gremlin-javascript project has no linter set so it's easy for code to be
> formatted differently depending on the editor used to save the changes
> From https://github.com/apache/tinkerpop/pull/1539#discussion_r818682368 we
> can implement eslint + airbnb's config to have a standard which editors would
> be able to pick up
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
