[
https://issues.apache.org/jira/browse/TINKERPOP-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511169#comment-17511169
]
ASF GitHub Bot commented on TINKERPOP-2716:
-------------------------------------------
spmallette commented on a change in pull request #1582:
URL: https://github.com/apache/tinkerpop/pull/1582#discussion_r833095947
##########
File path: gremlin-javascript/pom.xml
##########
@@ -236,6 +236,16 @@ file.write(file.getText("UTF-8").replaceFirst(/"version":
"(.*)",/, "\"version\"
<failOnError>true</failOnError>
</configuration>
</execution>
+ <execution>
+ <id>npm lint</id>
+ <phase>lint</phase>
Review comment:
the trouble i had with `validate` was that it was too early if we wanted
lint to consider generated sources. if we don't care about that then it's fine
to change it. doesn't really bother me either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Enable eslint for gremlin-javascript project
> --------------------------------------------
>
> Key: TINKERPOP-2716
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2716
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.5.2
> Reporter: Tom Kolanko
> Priority: Minor
>
> The gremlin-javascript project has no linter set so it's easy for code to be
> formatted differently depending on the editor used to save the changes
> From https://github.com/apache/tinkerpop/pull/1539#discussion_r818682368 we
> can implement eslint + airbnb's config to have a standard which editors would
> be able to pick up
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
