[ 
https://issues.apache.org/jira/browse/TINKERPOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513405#comment-17513405
 ] 

ASF GitHub Bot commented on TINKERPOP-2726:
-------------------------------------------

FlorianHockmann commented on pull request #1592:
URL: https://github.com/apache/tinkerpop/pull/1592#issuecomment-1080693208


   Using the Gherkin test suite to test the translators definitely sounds good 
to me. I would probably just execute the scenarios however with the translated 
code and then compare the results to what is expected in the scenario / feature.
   I think not all translations are 1:1 translations. `with()` is for example 
implemented as `WithStrategy(OptionsStrategy)` in the GLVs which isn't a 
problem for the translation but it complicates the comparison of just the 
bytecode.
   
   But we should probably discuss this separately. Do you want to create a 
ticket for this in JIRA so we don't forget about it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Python's GroovyTranslator translates boolean wrong
> --------------------------------------------------
>
>                 Key: TINKERPOP-2726
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2726
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: python
>    Affects Versions: 3.5.2
>            Reporter: Florian Hockmann
>            Assignee: Florian Hockmann
>            Priority: Trivial
>
> While working on a GroovyTranslator for .NET (TINKERPOP-2367), I used the 
> extensive Python test suite as a reference and noticed that boolean values 
> aren't translated correctly:
> {{True}} gets translated simply as {{{}True{}}}, but it should be {{true}} in 
> Groovy.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to