[ 
https://issues.apache.org/jira/browse/TINKERPOP-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514673#comment-17514673
 ] 

ASF GitHub Bot commented on TINKERPOP-2727:
-------------------------------------------

divijvaidya commented on a change in pull request #1596:
URL: https://github.com/apache/tinkerpop/pull/1596#discussion_r838490742



##########
File path: docs/src/reference/the-traversal.asciidoc
##########
@@ -1434,6 +1436,15 @@ the key,value pairs for those vertices.
 <6> Find all age-properties and emit their value.
 <7> Find all vertices that do not have an age-property and emit their name.
 <8> Find all "person" vertices that have a name property that starts with the 
letter "m".
+<9> Property key values cannot be `null` and therefore produces no matches.

Review comment:
       nit (feel free to ignore)
   
   perhaps rephrase to
   > Property Key is always stored as `String` and therefore an equality check 
with `null` will produce no result. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> HasContainer should allow a null key
> ------------------------------------
>
>                 Key: TINKERPOP-2727
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2727
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.5.2
>            Reporter: Florian Hockmann
>            Priority: Minor
>
> TINKERPOP-2605 changed {{null}} semantics to allow {{null}} as an argument in 
> more places so that {{has(null)}} should not throw a NPE any more and instead 
> filter all traversers out.
> {{HasContainer}} however still throws a NPE if the {{key}} is {{{}null{}}}.
> I discovered this when trying to update JanusGraph [as that folds in a 
> {{HasContainer}} like 
> this|https://github.com/JanusGraph/janusgraph/blob/4246d49cee46d549d752515f3956cd2d59f1fd0a/janusgraph-core/src/main/java/org/janusgraph/graphdb/tinkerpop/optimize/step/HasStepFolder.java#L266]
>  which leads to the NPE and thus failing tests.
> The same behavior can also be produced with just TinkerGraph and for example 
> the following traversals:
> {code:java}
> g.V().has(null, 1)
> g.V().has(null, P.neq(null)){code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to