[
https://issues.apache.org/jira/browse/TINKERPOP-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514679#comment-17514679
]
ASF GitHub Bot commented on TINKERPOP-2525:
-------------------------------------------
spmallette commented on a change in pull request #1605:
URL: https://github.com/apache/tinkerpop/pull/1605#discussion_r838502784
##########
File path:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Strategy/Decoration/SubgraphStrategy.cs
##########
@@ -53,6 +54,10 @@ public SubgraphStrategy() : base(JavaFqcn)
Configuration["edges"] = edges;
if (vertexProperties != null)
Configuration["vertexProperties"] = vertexProperties;
+
+ // hate to write this by default so only going to write it if it's
false which is the non-default value
Review comment:
decided to change it to always write it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Extend Gherkin tests to cover strategies
> ----------------------------------------
>
> Key: TINKERPOP-2525
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2525
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.4.10
> Reporter: Stephen Mallette
> Priority: Minor
>
> We now have a much more advanced test suite in 3.5.0 for processing Gherkin
> tests. We should extend the Gherkin tests further to include tests for
> {{TraversalStrategy}} instances.
> Of note {{SubgraphStrategy}} class doesn't have a {{checkAdjacentVertices}}
> parameter in its constructor.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
