gremlin-go is failing in GitHub Actions for my newly tagged 3.5.3. The problem seems obvious (i think), we're not doing a full build of the repo and therefore relying on external builds of whatever version we're currently trying to test:
https://github.com/apache/tinkerpop/blob/3.5.3/.github/workflows/build-test.yml#L239-L241 In this situation, 3.5.3 does not yet exist in any public maven repo so that part of the build fails. I think we should be doing a: mvn clean install -pl -:gremlin-javascript,-:gremlin-python,-gremlin-dotnet,-:gremlin-dotnet-source,-:gremlin-dotnet-tests -q -DskipTests -Dci there rather than those three separate commands. I'm also curious why that step should be last? shouldn't that happen ahead of running the godog tests so that the test files get updated properly if new tests are added to the .feature files? On Mon, Apr 4, 2022 at 2:44 PM Lyndon Bauto <[email protected]> wrote: > Thanks for exposing this issue Stephen. Myself or one of the other people > who has contributed to gremlin-go will take this item on and make sure we > get that working as expected. Agreed on not being a release blocker. > > On Mon, Apr 4, 2022 at 3:33 AM Stephen Mallette <[email protected]> > wrote: > > > Use of docker-compose seems to have some problems inside of our standard > > docker build, i.e. docker/build.sh doesn't work and fails the whole > build. > > I've disabled the gremlin-go tests until this can be resolved. Not a > > blocker for release imo. > > > > On Fri, Mar 18, 2022 at 4:22 PM Lyndon Bauto > > <[email protected]> wrote: > > > > > I think it would be great to use Docker to remove any environment setup > > > requirements, allowing new developers to more easily start with > > TinkerPop, > > > and current developers to test and use a new GLV without worrying about > > > setting up their system to run it. > > > > > > To answer your questions more specifically though: > > > > > > 1. Yes it does reference 3.5 - currently it loads an empty graph, > > > however an item we are looking to approach soon will be to load the > > > docker > > > graph with the datasets as well as the authentication built in. > > > 2. Yes, it would be possible for us to have it set up such that a > > > developer could build the docker server locally, reference it, then > > > execute > > > tests against it. > > > 3. Yes, that’s the idea. Anyone should be able to run the Gremlin-Go > > > integration tests locally without even installing Go. > > > 1. I think that removing the complicated Maven building for the > > > non-Java GLV’s and moving to a docker-compose style build > structure > > > would > > > provide a much simpler build environment for new developers. > > > 2. I’d like to discuss the idea of doing this, and in fact was > > > considering starting it after Gremlin-Go is complete. > > > > > > I'd appreciate any feedback from the community on this, for or against. > > > > > > On Fri, Mar 18, 2022 at 9:11 AM Stephen Mallette <[email protected] > > > > > wrote: > > > > > > > Lyndon (or anyone who might have thoughts) - I like the pattern > started > > > for > > > > making better use of docker to solve TinkerPop testing issues. We > need > > > more > > > > smart things to happen with docker to keep our code easy to build, > test > > > and > > > > manage. Now that i'm digging into it, I have developed some > > > > thoughts/questions. > > > > > > > > 1. I see the docker-compose.yml file and that it references the > Gremlin > > > > Server image of: tinkerpop/gremlin-server:3.5 but doesn't that just > > > start a > > > > Gremlin Server on 8182 which would start it with an empty graph by > > > default? > > > > where does the test data for all the different graphs required by > > Gherkin > > > > get loaded? > > > > > > > > 2. Is there a way to get docker-compose to use the local SNAPSHOT of > > > > Gremlin Server rather than pinning to tinkerpop/gremlin-server:3.5? > > > > > > > > 3. I think that this model gets rid of the complicated configuration > of > > > the > > > > .glv file which "turns on" the Maven <profile> for GLV building. We > can > > > > simply require Maven+docker-compose to do a build and streamline all > of > > > > that sort of stuff. Does that sound right? > > > > > > > > > > > > > -- > > > *Lyndon Bauto* > > > Team Lead > > > Bit Quill Technologies Inc. > > > [email protected] > > > https://www.bitquilltech.com > > > > > > > > -- > *Lyndon Bauto* > Team Lead > Bit Quill Technologies Inc. > [email protected] > https://www.bitquilltech.com >
