[
https://issues.apache.org/jira/browse/TINKERPOP-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17547202#comment-17547202
]
ASF GitHub Bot commented on TINKERPOP-2749:
-------------------------------------------
L0Lmaker commented on code in PR #1671:
URL: https://github.com/apache/tinkerpop/pull/1671#discussion_r889376669
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/.eslintrc.js:
##########
@@ -31,9 +31,9 @@ module.exports = {
extends: ['eslint:recommended', 'prettier'],
plugins: ['prettier'],
rules: {
- 'prettier/prettier': ['error'],
Review Comment:
There are two ways we could resolve this. Either allow for `CRLF` formatted
files or convert the existing javascript files that use the `CRLF` format to
`LF`. The former felt like a simpler fix which is why I disabled the check for
line separators.
If we want to keep it only Unix style, we could go ahead with converting all
the JS files that are affected.
> Support Windows Build
> ---------------------
>
> Key: TINKERPOP-2749
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2749
> Project: TinkerPop
> Issue Type: Improvement
> Reporter: Lyndon Bauto
> Assignee: Lyndon Bauto
> Priority: Major
>
> Currently the Windows build fails due to a number of issues. There are
> failures in:
> * gremlin-javascript
> * gremlin-dotnet-source
> * hadoop-gremlin
> * spark-gremlin
> * gremlint
> the hadoop-gremlin and spark-gremlin issues are a little more complex and
> will require additional investigation, but for now we can look to resolve the
> existing issues and get all other builds working in GitHub actions
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
