[
https://issues.apache.org/jira/browse/TINKERPOP-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550561#comment-17550561
]
ASF GitHub Bot commented on TINKERPOP-2693:
-------------------------------------------
lyndonbauto commented on code in PR #1676:
URL: https://github.com/apache/tinkerpop/pull/1676#discussion_r890323714
##########
gremlin-python/src/main/python/gremlin_python/structure/io/graphbinaryV1.py:
##########
@@ -255,15 +257,15 @@ class LongIO(_GraphBinaryTypeIO):
@classmethod
def dictify(cls, obj, writer, to_extend, as_value=False, nullable=True):
if obj < -9223372036854775808 or obj > 9223372036854775807:
- raise Exception("TODO: don't forget bigint")
+ raise Exception("Value too big, please use bigint Gremlin type")
Review Comment:
Spoke with both, both agreed with your technique.
> Complete GraphBinary support in Python
> --------------------------------------
>
> Key: TINKERPOP-2693
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2693
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.5.2
> Reporter: Stephen Mallette
> Assignee: Lyndon Bauto
> Priority: Major
>
> A bit surprising but it seems that GraphBinary still only has partial support
> in python. The remaining unsupported types aren't the most commonly needed so
> I'd imagine that's why there haven't been any complaints, but it would be
> good to get that completely done.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
