[
https://issues.apache.org/jira/browse/TINKERPOP-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555266#comment-17555266
]
ASF GitHub Bot commented on TINKERPOP-2751:
-------------------------------------------
codecov-commenter commented on PR #1714:
URL: https://github.com/apache/tinkerpop/pull/1714#issuecomment-1158048062
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1714?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1714](https://codecov.io/gh/apache/tinkerpop/pull/1714?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(1515212) into
[3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/60dd5f966a14965bedc56e0dd9abaa2b295061b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(60dd5f9) will **increase** coverage by `0.26%`.
> The diff coverage is `72.00%`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1714 +/- ##
===========================================
+ Coverage 63.00% 63.27% +0.26%
===========================================
Files 23 23
Lines 3411 3553 +142
===========================================
+ Hits 2149 2248 +99
- Misses 1109 1131 +22
- Partials 153 174 +21
```
| [Impacted
Files](https://codecov.io/gh/apache/tinkerpop/pull/1714?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[gremlin-go/driver/connection.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY29ubmVjdGlvbi5nbw==)
| `80.00% <0.00%> (-1.16%)` | :arrow_down: |
|
[gremlin-go/driver/error\_codes.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZXJyb3JfY29kZXMuZ28=)
| `100.00% <ø> (ø)` | |
|
[gremlin-go/driver/performance/performanceSuite.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcGVyZm9ybWFuY2UvcGVyZm9ybWFuY2VTdWl0ZS5nbw==)
| `0.00% <ø> (ø)` | |
|
[gremlin-go/driver/protocol.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcHJvdG9jb2wuZ28=)
| `63.20% <0.00%> (+0.99%)` | :arrow_up: |
|
[gremlin-go/driver/resultSet.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVzdWx0U2V0Lmdv)
| `80.18% <18.75%> (-10.14%)` | :arrow_down: |
|
[gremlin-go/driver/graphBinary.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhCaW5hcnkuZ28=)
| `53.79% <64.41%> (+2.75%)` | :arrow_up: |
|
[gremlin-go/driver/strategies.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvc3RyYXRlZ2llcy5nbw==)
| `65.69% <64.78%> (-1.48%)` | :arrow_down: |
|
[gremlin-go/driver/traversal.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvdHJhdmVyc2FsLmdv)
| `70.54% <83.33%> (+0.23%)` | :arrow_up: |
|
[gremlin-go/driver/graphTraversalSource.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhUcmF2ZXJzYWxTb3VyY2UuZ28=)
| `80.89% <85.00%> (ø)` | |
|
[gremlin-go/driver/graphTraversal.go](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ3JhcGhUcmF2ZXJzYWwuZ28=)
| `89.11% <89.62%> (+0.77%)` | :arrow_up: |
| ... and [8
more](https://codecov.io/gh/apache/tinkerpop/pull/1714/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1714?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1714?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[8691929...1515212](https://codecov.io/gh/apache/tinkerpop/pull/1714?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> Transaction: tx.commit() hangs up in javascript client-lib
> ----------------------------------------------------------
>
> Key: TINKERPOP-2751
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2751
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript, server
> Affects Versions: 3.6.0
> Reporter: Stefan Templin
> Priority: Minor
> Labels: Transaction
>
> Hi,
> I am trying to get transactions working for a while now, but no matter what i
> do, i can't get the transaction to commit.
> h3. My Setup:
> * Running gremlin-server 3.6.0 in Docker on localhost using the
> default-configuration.
> {code}
> version: '3.7'
> services:
> gremlin:
> image: tinkerpop/gremlin-server:3.6.0
> container_name: gremlin
> restart: always
> ports:
> - "8182:8182"
> {code}
> * Javascript-Gremlin-lib 3.6.0
> h3. Problem:
> Im executing the following code:
>
> {code:js}
> const dc = new DriverRemoteConnection('ws://localhost:8182/gremlin', {
> 'rejectUnauthorized': false});
> const g = traversal().withRemote(dc);
> const tx = g.tx();
> const gtx = tx.begin();
> try {
> await gtx.addV('person').iterate();
> await gtx.addV('software').iterate();
> await tx.commit();
> // stuck here
> console.log('here')
> } catch (err) {
> await tx.rollback();
> } finally {
> await dc.close();
> }{code}
> The code just will never get past 'await tx.commit()', no error, nothing. It
> just hangs up there. The code before that is properly executed and the Graph
> contains both vertices.
> Am I doing anything wrong there, or are transactions not working properly?
> Hope you can help me with that.
>
> Kind regards,
> Stefan
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
