[
https://issues.apache.org/jira/browse/TINKERPOP-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556387#comment-17556387
]
ASF GitHub Bot commented on TINKERPOP-2734:
-------------------------------------------
spmallette commented on PR #1697:
URL: https://github.com/apache/tinkerpop/pull/1697#issuecomment-1160459458
generally speaking, i don't really see anything wrong with this change. i
dont' think it introduces anything bad and the decoupling of logic is probably
a good idea. could we question the theory of this change a bit though? i
suppose the assumption here that `connectionPool` is somehow `null` when it
gets to `SessionedClient.chooseConnection()` and that is the NPE. if so, what
circumstance allows that to happen and how does this change either potentially
fix or better expose that problem?
> NullPointerException when calling Client chooseConnection()
> -----------------------------------------------------------
>
> Key: TINKERPOP-2734
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2734
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
> Affects Versions: 3.5.2
> Reporter: Mark Bennett
> Priority: Major
>
> This is similar to TINKERPOP-2597 and reported fixed in gremlin driver 3.5.2.
> However, we are still getting intermittent null pointer exceptions, and our
> stack trace it a bit different:
> {code:java}
> java.lang.NullPointerException: null
> at
> org.apache.tinkerpop.gremlin.driver.Client$SessionedClient.chooseConnection(Client.java:813)
> at org.apache.tinkerpop.gremlin.driver.Client.submitAsync(Client.java:390)
> at org.apache.tinkerpop.gremlin.driver.Client.submitAsync(Client.java:373)
> at org.apache.tinkerpop.gremlin.driver.Client.submitAsync(Client.java:298)
> at org.apache.tinkerpop.gremlin.driver.Client.submit(Client.java:250)
> {code}
> In addition we see this in our logs:
> class=org.apache.tinkerpop.gremlin.driver.ConnectionPool
> Signalled closing of connection pool on Host\{..}
> class=org.apache.tinkerpop.gremlin.driver.Client
> Could not initialize client for Optional[..]
> Seeing a lot of this too:
> Timed-out (16000 MILLISECONDS) waiting for connection on Host{}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
