[
https://issues.apache.org/jira/browse/TINKERPOP-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556817#comment-17556817
]
ASF GitHub Bot commented on TINKERPOP-2761:
-------------------------------------------
spmallette commented on PR #1716:
URL: https://github.com/apache/tinkerpop/pull/1716#issuecomment-1161585397
> In the mentioned thread, it seems to read the version key from hbase jar
sorry - i read that thread but github didn't display the discussion in whole
and i missed some additional comments
as i recall there isn't any standard to manifest files keys. rather than
camel case of `tinkerpopVersion` could you please change it to
`tinkerpop-version` ?
> Gremlin: use another manifest name for version
> ----------------------------------------------
>
> Key: TINKERPOP-2761
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2761
> Project: TinkerPop
> Issue Type: Improvement
> Reporter: Boxuan Li
> Priority: Major
>
> In Gremlin.java, the gremlin version is read from a version attribute:
> {code:java}
> version = Manifests.read("version");{code}
> This name is too general and can be overridden accidentally, see
> [https://github.com/JanusGraph/janusgraph/discussions/3004]
> I propose we use a more specific name, such as "tinkerpopVersion".
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
