Fixing a typo -> "I am completely *not* sure about this but perhaps..."
-- Divij Vaidya On Sat, Jul 23, 2022 at 12:04 PM Divij Vaidya <[email protected]> wrote: > Hey Kelvin > > Thank you for picking up the responsibility for the release process. I > have a couple of questions before I can vote to go ahead with the release. > > 1. I was looking at the commits going in the release and found that we are > missing mention of certain changes in the changelog such as > https://github.com/apache/tinkerpop/commit/e92d53fa0767fafa4e74f12ca84542d77d7d2976, > > https://github.com/apache/tinkerpop/commit/81f884e2782939ddaf338ec87b38ad67690bc0a8 > and > https://github.com/apache/tinkerpop/commit/ae720befe507cd3385d32e7bd91229bd51758ea8. > Please correct me if I am wrong but I would assume that all relevant > changes (even if they are part of RC version of go client) should be added > to the changelog? If you agree, I can do an exhaustive run though the > commits on Monday and fix the change log. > > 2. I performed some sanity checks by downloading the binary and connecting > the server via the console. I observed some warnings while starting the > console but I think those are not release blocking. > > dev-dsk-diviv-1a-190badd5 % ./bin/gremlin.sh > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by > org.codehaus.groovy.reflection.CachedClass > (file:/local/home/diviv/apache-tinkerpop-gremlin-console-3.5.4/lib/groovy-2.5.14-indy.jar) > to method java.lang.Object.finalize() > WARNING: Please consider reporting this to the maintainers of > org.codehaus.groovy.reflection.CachedClass > WARNING: Use --illegal-access=warn to enable warnings of further illegal > reflective access operations > WARNING: All illegal access operations will be denied in a future release > > 3. Since Kelvin, you are performing the release and signing it, would we > require you to add your public keys to > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS? I am completely > sure about this but perhaps @Stephen Mallette <[email protected]> might > be able to answer this one. > > dev-dsk-diviv-1a-190badd5 % gpg --verify > apache-tinkerpop-gremlin-console-3.5.4-bin.zip.asc > apache-tinkerpop-gremlin-console-3.5.4-bin.zip > gpg: Signature made Tue 19 Jul 2022 09:27:18 PM UTC using RSA key ID > 01B1989A > gpg: Good signature from "Stephen Mallette <[email protected]>" > gpg: WARNING: This key is not certified with a trusted signature! > gpg: There is no indication that the signature belongs to the > owner. > Primary key fingerprint: 8D8C 72F9 4E0D E6A6 7E1B 87A7 6F38 BF38 01B1 989A > > 4. I ran the tests for the 3.5.4 branch and ensured that all tests passed. > I did not verify that the number of tests running for 3.5.4 >= number of > tests running for 3.5.3. > > -- > Divij Vaidya > > > > On Fri, Jul 22, 2022 at 11:52 PM Florian Hockmann <[email protected]> > wrote: > >> I checked the links and everything looks good. Thanks for taking care of >> the releases. >> >> VOTE +1 >> >> ________________________________ >> Von: Kelvin Lawrence <[email protected]> >> Gesendet: Mittwoch, 20. Juli 2022 23:05 >> An: [email protected] >> Betreff: Subject: [VOTE] TinkerPop 3.5.4 Release >> >> Hello, >> >> We are happy to announce that TinkerPop 3.5.4 is ready for release. >> >> The release artifacts can be found at this location: >> https://dist.apache.org/repos/dist/dev/tinkerpop/3.5.4/ >> >> The source distribution is provided by: >> apache-tinkerpop-3.5.4-src.zip >> >> Two binary distributions are provided for user convenience: >> apache-tinkerpop-gremlin-console-3.5.4-bin.zip >> apache-tinkerpop-gremlin-server-3.5.4-bin.zip >> >> The GPG key used to sign the release artifacts is available at: >> https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS >> >> The online docs can be found here: >> https://tinkerpop.apache.org/docs/3.5.4/ (user docs) >> https://tinkerpop.apache.org/docs/3.5.4/upgrade/ (upgrade docs) >> https://tinkerpop.apache.org/javadocs/3.5.4/core/ (core javadoc) >> https://tinkerpop.apache.org/javadocs/3.5.4/full/ (full javadoc) >> https://tinkerpop.apache.org/dotnetdocs/3.5.4/ (.NET API docs) >> https://tinkerpop.apache.org/jsdocs/3.5.4/ (Javascript API docs) >> >> The Git tag can be found here: >> https://github.com/apache/tinkerpop/tree/3.5.4 >> >> The release notes are available here: >> https://github.com/apache/tinkerpop/blob/3.5.4/CHANGELOG.asciidoc >> >> The [VOTE] will be open for the next 72 hours --- closing Saturday (July >> 23rd 2022) at 21:00 GMT (16:00 US CDT) >> >> My vote is +1. >> >> Thank you very much, >> Kelvin Lawrence >> >
