[
https://issues.apache.org/jira/browse/TINKERPOP-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611085#comment-17611085
] ASF GitHub Bot commented on TINKERPOP-2794: ------------------------------------------- codecov-commenter commented on PR #1818: URL: https://github.com/apache/tinkerpop/pull/1818#issuecomment-1262422385 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1818?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1818](https://codecov.io/gh/apache/tinkerpop/pull/1818?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e55920b) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/81688b6b55e555c6d74a5ff8aeb43b87fac539ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81688b6) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.5-dev #1818 +/- ## ============================================= - Coverage 69.43% 69.41% -0.02% + Complexity 8925 8922 -3 ============================================= Files 861 861 Lines 40858 40858 Branches 5384 5384 ============================================= - Hits 28371 28363 -8 - Misses 10584 10588 +4 - Partials 1903 1907 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../gremlin/driver/exception/ConnectionException.java](https://codecov.io/gh/apache/tinkerpop/pull/1818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9leGNlcHRpb24vQ29ubmVjdGlvbkV4Y2VwdGlvbi5qYXZh) | `22.22% <0.00%> (-22.23%)` | :arrow_down: | | [...java/org/apache/tinkerpop/gremlin/driver/Host.java](https://codecov.io/gh/apache/tinkerpop/pull/1818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Ib3N0LmphdmE=) | `47.05% <0.00%> (-2.95%)` | :arrow_down: | | [...kerpop/gremlin/server/handler/AbstractSession.java](https://codecov.io/gh/apache/tinkerpop/pull/1818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9oYW5kbGVyL0Fic3RyYWN0U2Vzc2lvbi5qYXZh) | `41.74% <0.00%> (-0.91%)` | :arrow_down: | | [...pache/tinkerpop/gremlin/driver/ConnectionPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uUG9vbC5qYXZh) | `30.65% <0.00%> (-0.77%)` | :arrow_down: | | [...rg/apache/tinkerpop/gremlin/driver/Connection.java](https://codecov.io/gh/apache/tinkerpop/pull/1818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uLmphdmE=) | `67.56% <0.00%> (ø)` | | | [...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `90.45% <0.00%> (+0.18%)` | :arrow_up: | | [...nkerpop/gremlin/groovy/engine/GremlinExecutor.java](https://codecov.io/gh/apache/tinkerpop/pull/1818/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1ncm9vdnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2dyb292eS9lbmdpbmUvR3JlbWxpbkV4ZWN1dG9yLmphdmE=) | `87.71% <0.00%> (+0.42%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Allow cancellation of Gremlin.Net async methods > ----------------------------------------------- > > Key: TINKERPOP-2794 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2794 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet > Reporter: Bill Poole > Assignee: Florian Hockmann > Priority: Major > > Gremlin.Net async methods such as Promise do not accept a CancellationToken > parameter and cannot therefore be cancelled. Applications often need to be > closed quickly/responsively when a user quits or an application server > component is shut down/rebooted - e.g., during cluster auto > scaling/rebalancing. > All async methods should accept a CancellationToken parameter (which can be > given a default value of 'default'). -- This message was sent by Atlassian Jira (v8.20.10#820010)
