[ 
https://issues.apache.org/jira/browse/TINKERPOP-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617051#comment-17617051
 ] 

ASF GitHub Bot commented on TINKERPOP-2471:
-------------------------------------------

codecov-commenter commented on PR #1827:
URL: https://github.com/apache/tinkerpop/pull/1827#issuecomment-1277610769

   # 
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#1827](https://codecov.io/gh/apache/tinkerpop/pull/1827?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (dc30d07) into 
[3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/62ae81216b4cd9b5c4f209e9c40b6b912af8ad2e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (62ae812) will **increase** coverage by `0.03%`.
   > The diff coverage is `40.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             3.5-dev    #1827      +/-   ##
   =============================================
   + Coverage      69.38%   69.42%   +0.03%     
   - Complexity      8924     8926       +2     
   =============================================
     Files            861      861              
     Lines          40858    40860       +2     
     Branches        5384     5385       +1     
   =============================================
   + Hits           28350    28367      +17     
   + Misses         10606    10592      -14     
   + Partials        1902     1901       -1     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/tinkerpop/pull/1827?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...trategy/optimization/TinkerGraphCountStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGlua2VyZ3JhcGgtZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vdGlua2VyZ3JhcGgvcHJvY2Vzcy90cmF2ZXJzYWwvc3RyYXRlZ3kvb3B0aW1pemF0aW9uL1RpbmtlckdyYXBoQ291bnRTdHJhdGVneS5qYXZh)
 | `85.00% <0.00%> (ø)` | |
   | 
[...lin/process/computer/traversal/WorkerExecutor.java](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9Xb3JrZXJFeGVjdXRvci5qYXZh)
 | `90.26% <50.00%> (-1.63%)` | :arrow_down: |
   | 
[.../step/map/ConnectedComponentVertexProgramStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9zdGVwL21hcC9Db25uZWN0ZWRDb21wb25lbnRWZXJ0ZXhQcm9ncmFtU3RlcC5qYXZh)
 | `70.58% <0.00%> (-5.89%)` | :arrow_down: |
   | 
[...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==)
 | `90.63% <0.00%> (-0.19%)` | :arrow_down: |
   | 
[...e/tinkerpop/gremlin/server/util/MetricManager.java](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci91dGlsL01ldHJpY01hbmFnZXIuamF2YQ==)
 | `52.48% <0.00%> (+0.55%)` | :arrow_up: |
   | 
[gremlin-go/driver/gorillaTransporter.go](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ29yaWxsYVRyYW5zcG9ydGVyLmdv)
 | `66.98% <0.00%> (+2.83%)` | :arrow_up: |
   | 
[.../traversal/step/map/PageRankVertexProgramStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9zdGVwL21hcC9QYWdlUmFua1ZlcnRleFByb2dyYW1TdGVwLmphdmE=)
 | `76.74% <0.00%> (+4.65%)` | :arrow_up: |
   | 
[...rg/apache/tinkerpop/gremlin/driver/Connection.java](https://codecov.io/gh/apache/tinkerpop/pull/1827/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9Db25uZWN0aW9uLmphdmE=)
 | `66.89% <0.00%> (+9.45%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   




> Add logging to Gremlin.Net driver
> ---------------------------------
>
>                 Key: TINKERPOP-2471
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2471
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>            Reporter: Florian Hockmann
>            Priority: Minor
>
> It would be helpful to have logging in the driver to get insights into its 
> internal state. Examples for events that we could log are:
>  * A connection is dead & will be replaced.
>  * The pool is empty, so we cannot get a connection for the current request 
> (but will probably try again)
> This should make it more transparent for users how the driver operates and 
> what its current state is.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to