If you think it's helpful, I'd say that's fine. Are you suggesting it be moved from gremlin-driver/src/test to gremlin-server/src/main? maybe it would go best in a new /server/util/test package?
The only problem with moving it is that you end up with a circular relationship. gremlin-server depends on gremlin-driver so if you move it the gremlin-driver tests that depend on it won't work anymore. It's a bit weird but maybe you keep it in gremlin-driver and just move it to gremlin-driver/.../util/test? Or I guess the driver tests could move to gremlin-server along with the SimpleSocketServer related classes? that's a bit weird too though. Or maybe a new module is on order? create gremlin-tools/gremlin-socket-server? i think you'd avoid dependency issues there between gremlin-driver and gremlin-server and the GLVs. Maybe this is the best way as it would allow the independent development of a really robust test server without muddying existing packages with test components. Sorry, I just sorta rambled my way to that last point which seems like it could be the best one. On Fri, Oct 14, 2022 at 4:27 PM Cole Greer <[email protected]> wrote: > Hi everyone, > > I have been working on TINKERPOP-2480 according to Ken's recent > proposal (https://lists.apache.org/thread/x8lt6mk04r7h0nsdy9q3pz1pbo1t28tj > ). > I have found that the SimpleSocketServer combined with > TestWSGremlinInitializer in Gremlin-Driver to be a very useful > resource for creating tests which require custom response behaviour > from the server. From what I have seen this is something which the > other GLV's are currently lacking. I believe having such a test server > accessible to the other GLV's would be a useful step towards > standardizing the testing between all the GLV's and bringing more > behavioural tests to the GLV's. In order to do this I would propose > moving the SimpleSocketServer from the tinkerpop.gremlin.driver > package to tinkerpop.gremlin.server and running it in the existing > gremlin-server-test docker container on a new port. > > I would greatly appreciate any feedback on this idea, whether you find > it to be useful or have any concerns. > > Thanks, > > Cole >
