[
https://issues.apache.org/jira/browse/TINKERPOP-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624728#comment-17624728
]
ASF GitHub Bot commented on TINKERPOP-2814:
-------------------------------------------
kenhuuu commented on code in PR #1833:
URL: https://github.com/apache/tinkerpop/pull/1833#discussion_r1006134782
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -986,13 +996,26 @@ public Builder port(final int port) {
* handshake and SSL handshake. Beyond this duration an exception
would be thrown.
*
* Note that this value should be greater that SSL handshake timeout
defined in
- * {@link io.netty.handler.ssl.SslHandler} since WebSocket handshake
include SSL handshake.
+ * {@link io.netty.handler.ssl.SslHandler} since WebSocket handshake
include SSL handshake. This value should be
+ * less than {@link Builder#maxWaitForConnection}.
Review Comment:
Could you clarify this? Did you mean adding a param line? If so, I didn't do
this as it seemed a bit redundant and it isn't done for any of the other params
in this class.
> Add a SSL handshake timeout configuration to the driver
> -------------------------------------------------------
>
> Key: TINKERPOP-2814
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2814
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.5.4
> Reporter: Stephen Mallette
> Priority: Blocker
>
> The java driver currently relies on the default 10 second SSL handshake
> timeout defined by Netty. Add a configuration to the driver to allow users to
> change that setting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
