[
https://issues.apache.org/jira/browse/TINKERPOP-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652240#comment-17652240
]
ASF GitHub Bot commented on TINKERPOP-2842:
-------------------------------------------
spmallette commented on code in PR #1916:
URL: https://github.com/apache/tinkerpop/pull/1916#discussion_r1057652790
##########
gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinScriptCheckerTest.java:
##########
@@ -53,6 +104,14 @@ public void shouldIdentifyTimeoutAsStringKeySingleQuoted() {
getTimeout().get().longValue());
}
+ @Test
+ public void shouldIdentifyRequestIdAsStringKeySingleQuoted() {
+ assertEquals("db024fca-ed15-4375-95de-4c6106aef895",
GremlinScriptChecker.parse("g.with('requestId',
'db024fca-ed15-4375-95de-4c6106aef895').with(true).V().out('knows')").
Review Comment:
yes - should pick up any string really. modified one of the tests to do
uppercase uuid though to just make the test more realistic to what people would
submit.
> Expand GremlinScriptChecker to include request id overrides
> -----------------------------------------------------------
>
> Key: TINKERPOP-2842
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2842
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.4
> Reporter: Stephen Mallette
> Priority: Major
>
> Expand {{GremlinScriptChecker}} to parse for a overridden request id as in:
> {code}
> g.with(REQUEST_ID, 'xxx')
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
