Hi Florian, https://github.com/apache/tinkerpop/pull/1923 is targeting the master branch as those tests are utilizing the changes to gremlin-socket-server from https://issues.apache.org/jira/browse/TINKERPOP-2819. I would still like to get this PR merged soon but it should not factor into the release discussion.
I was also hoping we could sneak in https://github.com/apache/tinkerpop/pull/1933 before the release is made. It simply adds a bit more detail to the docs regarding the dedup step and shouldn't be cause for any concern. It is definitely in the "nice to haves" category and not critical though so it is not a big concern if it misses the release for any reason. Regards, Cole Greer From: Florian Hockmann <f...@florian-hockmann.de> Date: Monday, January 9, 2023 at 12:23 AM To: dev@tinkerpop.apache.org <dev@tinkerpop.apache.org> Subject: AW: [DISCUSS] Next releases: 3.5.5 / 3.6.2 / 3.7.0 (?) OK, then let's start code freeze now. This affects the 3.5-dev and 3.6-dev branches. I plan to still merge this PR as it adds tests for the added user agent functionality that was already merged and these changes should be low risk: https://github.com/apache/tinkerpop/pull/1923 If there are any other PRs that you like to merge during code freeze, please respond here. -----Ursprüngliche Nachricht----- Von: Stephen Mallette <spmalle...@gmail.com> Gesendet: Freitag, 6. Januar 2023 19:53 An: dev@tinkerpop.apache.org Betreff: Re: [DISCUSS] Next releases: 3.5.5 / 3.6.2 / 3.7.0 (?) Mike's PR looks about ready to land. Code freeze can trigger today from my perspective. On Mon, Jan 2, 2023 at 9:02 AM Mike Personick <m...@dayzero.io> wrote: > Florian, I am back in the office today after the holiday break and am > aiming to wrap up by mid to end of week. I only have test cases and > cleanup left. > > Thanks, > Mike > > On Mon, Jan 2, 2023 at 2:21 AM Florian Hockmann > <f...@florian-hockmann.de> > wrote: > > > A bit late with my response here, but I think it doesn't really > > matter whether we would have started code freeze last week or maybe > > early next week. > > > > However, the tests for TINKERPOP-2813 are still missing and Mike's > > proposals to change mergeV/E semantics are also still open, right? > > From my side, we can wait for these contributions and then start > > code freeze once they are in place. If the changes to mergeV/E > > however take > more > > than a few weeks, then we might want to move them to a follow-up release. > > @Mike: Do you have any estimate how long this will take? Or is > > someone else working on this? > > > > -----Ursprüngliche Nachricht----- > > Von: Stephen Mallette <spmalle...@gmail.com> > > Gesendet: Montag, 19. Dezember 2022 12:34 > > An: dev@tinkerpop.apache.org > > Betreff: Re: [DISCUSS] Next releases: 3.5.5 / 3.6.2 / 3.7.0 (?) > > > > Aside for review on some additional tests for TINKERPOP-2813, i > > think all items here are resolved. The only thing left on > > 3.5.5/3.6.2 are mike's recent threads. That might set things up to > > head to code freeze by end of the year. > > > > On Mon, Nov 28, 2022 at 10:37 AM Stephen Mallette > > <spmalle...@gmail.com> > > wrote: > > > > > I'd also point out this one as a blocker: > > > > > > https://issues.apache.org/jira/browse/TINKERPOP-2807 > > > > > > Not sure if it needs to be fixed necessarily - it could perhaps be > > > mitigated from blocker status with documentation on best practices > > > for how to deal with this deficiency until a fix is actually prepared. > > > > > > > > > > > > On Mon, Nov 28, 2022 at 9:02 AM Florian Hockmann > > > <f...@florian-hockmann.de> > > > wrote: > > > > > >> Thanks everyone for your input on this! Then let's wait with > > >> 3.5.5 and > > >> 3.6.2 until those issues are resolved. > > >> > > >> And for 3.7.0 we also seem to have a consensus to move its target > > >> date into 2023. I'll update our roadmap for that [1]. > > >> > > >> [1]: > > >> https://github.com/apache/tinkerpop/blob/master/docs/src/dev/futu > > >> re/i > > >> ndex.asciidoc#37x---target-22q4 > > >> > > >> -----Ursprüngliche Nachricht----- > > >> Von: Stephen Mallette <spmalle...@gmail.com> > > >> Gesendet: Montag, 28. November 2022 12:57 > > >> An: dev@tinkerpop.apache.org > > >> Betreff: Re: [DISCUSS] Next releases: 3.5.5 / 3.6.2 / 3.7.0 (?) > > >> > > >> Agree with Ken about TINKERPOP-2813. It's a delicate bunch of > > >> changes that need a lot of testing unfortunately. Maybe ready for > > >> a PR within the next couple of weeks. There's also another issue > > >> with gremlin-tests in 3.6.x that should be fixed with the gherkin tests. > > >> They really should be moved to test resources so that they can be > > >> more easily referenced as such by providers. That's not a hard > > >> one I > > don't think. > > >> > > >> On Sat, Nov 26, 2022 at 2:31 PM David Bechberger > > >> <d...@bechberger.com> > > >> wrote: > > >> > > >> > I also agree that moving the 3.7 date to 2023 and maintaining > > >> > the > > >> > 3.5.5/3.6.2 release branches makes the most sense for where the > > >> > community is at. > > >> > > > >> > Dave > > >> > > > >> > On Wed, Nov 23, 2022 at 11:09 AM Ken Hu > > >> > <k...@bitquilltech.com.invalid> > > >> > wrote: > > >> > > > >> > > Hi Florian, > > >> > > > > >> > > I've compiled a list of items in response to your question > > >> > > about open issues/PRs that we would want before a 3.5.5/3.6.2 > > >> > > release. > > >> > > They are as > > >> > > follows: > > >> > > > > >> > > Open Issues > > >> > > TINKERPOP-2813. This is an important issue for handling > > >> > > NoHostAvailable exceptions. > > >> > > > > >> > > Open Pull Requests > > >> > > 1833 (TINKERPOP-2814) Removing default SSL handshake timeout. > > >> > > 1838 (TINKERPOP-2480) Adding a User-Agent to the WebSocket > > handshake. > > >> > > 1836 (TINKERPOP-2818) Excluding mockito-core from gremlin-core. > > >> > > 1860/1846 Better error messages. > > >> > > > > >> > > These items should be completed in the coming weeks and so a > > >> > > release can still likely be targeted for the end of this year. > > >> > > > > >> > > Regards, > > >> > > Ken > > >> > > > > >> > > > > >> > > On Wed, Nov 23, 2022 at 6:21 AM Jorge Bay Gondra < > > >> > jorgebaygon...@gmail.com > > >> > > > > > >> > > wrote: > > >> > > > > >> > > > I agree with moving the target date for 3.7.0 and only > > >> > > > releasing > > >> > > > 3.5.5 > > >> > > and > > >> > > > 3.6.2 for now. > > >> > > > > > >> > > > > > >> > > > On Wed, Nov 23, 2022 at 12:20 PM Florian Hockmann < > > >> > > f...@florian-hockmann.de> > > >> > > > wrote: > > >> > > > > > >> > > > > Hi, > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > our last release was already in July, and I think we now > > >> > > > > have a lot > > >> > of > > >> > > > > contributions in the dev branches, so I'd like to propose > > >> > > > > we do a > > >> > > release > > >> > > > > soon. > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > Now, the question is: Do we only want to release 3.5.5 > > >> > > > > and > > >> > > > > 3.6.2 or > > >> > do > > >> > > we > > >> > > > > also already want to release 3.7.0 at this point? > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > The CHANGELOG for 3.7.0 currently lists a few changes, > > >> > > > > but I think > > >> > the > > >> > > > only > > >> > > > > major change is the added support for mid-traversal > > >> > > > > E()-steps.[1] Our current plan for the 3.7.0 release > > >> > > > > however lists quite a number of > > >> > > > features > > >> > > > > that we wanted to implement in that version.[2] > > >> > > > > > > >> > > > > We can now either decide to move the features that are > > >> > > > > not > > >> > implemented > > >> > > > yet > > >> > > > > (and not expected to be implemented in the next few > > >> > > > > weeks) to version > > >> > > > 3.8.0 > > >> > > > > or not release 3.7.0 at this point and instead move its > > >> > > > > target > > >> > release > > >> > > > date > > >> > > > > to 2023. > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > If we decide to release 3.7.0 at this point, then we > > >> > > > > should also > > >> > > discuss > > >> > > > > whether we want to continue supporting the 3.5 line or > > >> > > > > making > > >> > > > > 3.5.5 > > >> > the > > >> > > > > last > > >> > > > > release. If we want to continue supporting it, then we > > >> > > > > have 4 active > > >> > > dev > > >> > > > > branches (3.5-dev, 3.6-dev, 3.7-dev, and master for 3.8.0). > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > I suggest that we move the target release date for 3.7.0 > > >> > > > > to > > >> > > > > 2023 as > > >> > > most > > >> > > > of > > >> > > > > the planned features are not ready yet and because most > > >> > > > > (all?) graph providers haven't even updated to 3.6 yet > > >> > > > > which also means that we > > >> > > > probably > > >> > > > > want to continue supporting 3.5. Having to support 4 > > >> > > > > branches however > > >> > > > adds > > >> > > > > some burden to our development workflow. > > >> > > > > > > >> > > > > Any thoughts on this? > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > Now to 3.5.5 and 3.6.2, I think we have quite some > > >> > > > > contributions > > >> > ready > > >> > > > for > > >> > > > > these releases, including some updates that fix security > > >> > > vulnerabilities. > > >> > > > > Are there any open issues / PRs that should definitely be > > >> > > > > included in > > >> > > > these > > >> > > > > releases? > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > [1]: > > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > https://github.com/apache/tinkerpop/blob/master/CHANGELOG.ascii > > >> > doc# > > >> > tin > > >> > kerpop > > >> > > > > -370-release-date-not-officially-released-yet > > >> > > > > < > > >> > > > > > >> > > > > >> > https://github.com/apache/tinkerpop/blob/master/CHANGELOG.ascii > > >> > doc# tin kerpop-370-release-date-not-officially-released-yet > > >> > > > > > > >> > > > > > > >> > > > > [2]: > > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > https://github.com/apache/tinkerpop/blob/master/docs/src/dev/fu > > >> > ture > > >> > /in > > >> > dex.as > > >> > > > > ciidoc#37x---target-22q4 > > >> > > > > < > > >> > > > > > >> > > > > >> > https://github.com/apache/tinkerpop/blob/master/docs/src/dev/fu > > >> > ture > > >> > /in > > >> > dex.asciidoc#37x---target-22q4 > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > > > >
