[
https://issues.apache.org/jira/browse/TINKERPOP-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675730#comment-17675730
]
ASF GitHub Bot commented on TINKERPOP-2844:
-------------------------------------------
vkagamlyk commented on code in PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#discussion_r1067484871
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##########
@@ -64,5 +63,15 @@ describe('Client', function () {
await noUserAgentClient.close();
});
+ it('should send per request settings to server', async function () {
+ let resultSet = await client.submit('1', null, {
Review Comment:
better to use `const` to declare immutable variable
> Test and Fix Per Request Settings in Python
> -------------------------------------------
>
> Key: TINKERPOP-2844
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2844
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.7.0, 3.6.1, 3.5.4
> Reporter: Cole Greer
> Priority: Major
>
> Gremlin python gives the option to override certain settings on a per request
> basis (detailed
> [here|https://tinkerpop.apache.org/docs/current/reference/#_per_request_settings_5]).
> It's been observed that when overriding the requestId, gremlin python will
> still make and use a new requestId instead. All documented per request
> settings need to be tested and fixed if needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
