[
https://issues.apache.org/jira/browse/TINKERPOP-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675754#comment-17675754
] ASF GitHub Bot commented on TINKERPOP-2841: ------------------------------------------- codecov-commenter commented on PR #1939: URL: https://github.com/apache/tinkerpop/pull/1939#issuecomment-1379646014 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1939](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d08d0d) into [master](https://codecov.io/gh/apache/tinkerpop/commit/e4d3732ce69719f7f41bc411a5a2955b60858d6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4d3732) will **increase** coverage by `0.43%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #1939 +/- ## ============================================ + Coverage 68.59% 69.02% +0.43% + Complexity 9087 9085 -2 ============================================ Files 854 830 -24 Lines 41179 37451 -3728 Branches 5597 5597 ============================================ - Hits 28248 25852 -2396 + Misses 10953 9789 -1164 + Partials 1978 1810 -168 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../traversal/step/map/PageRankVertexProgramStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9zdGVwL21hcC9QYWdlUmFua1ZlcnRleFByb2dyYW1TdGVwLmphdmE=) | `72.09% <0.00%> (-4.66%)` | :arrow_down: | | [...a/org/apache/tinkerpop/gremlin/server/Context.java](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9Db250ZXh0LmphdmE=) | `81.69% <0.00%> (-1.41%)` | :arrow_down: | | [...apache/tinkerpop/gremlin/server/GremlinServer.java](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9HcmVtbGluU2VydmVyLmphdmE=) | `56.09% <0.00%> (-0.98%)` | :arrow_down: | | [...mlin/server/op/traversal/TraversalOpProcessor.java](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9vcC90cmF2ZXJzYWwvVHJhdmVyc2FsT3BQcm9jZXNzb3IuamF2YQ==) | `47.46% <0.00%> (-0.93%)` | :arrow_down: | | [gremlin-go/driver/client.go](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY2xpZW50Lmdv) | | | | [gremlin-go/driver/driverRemoteConnection.go](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZHJpdmVyUmVtb3RlQ29ubmVjdGlvbi5nbw==) | | | | [gremlin-go/driver/request.go](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVxdWVzdC5nbw==) | | | | [gremlin-go/driver/protocol.go](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcHJvdG9jb2wuZ28=) | | | | [gremlin-go/driver/serializer.go](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvc2VyaWFsaXplci5nbw==) | | | | [gremlin-go/driver/traversal.go](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvdHJhdmVyc2FsLmdv) | | | | ... and [20 more](https://codecov.io/gh/apache/tinkerpop/pull/1939?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Test and Fix Per Request Settings in Go > --------------------------------------- > > Key: TINKERPOP-2841 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2841 > Project: TinkerPop > Issue Type: Improvement > Components: go > Affects Versions: 3.7.0, 3.6.1, 3.5.4 > Reporter: Cole Greer > Priority: Major > > Gremlin go gives the option to override certain settings on a per request > basis (detailed > [here|https://tinkerpop.apache.org/docs/current/reference/#_per_request_settings_4]). > It's been observed that when overriding the requestId, gremlin go will still > make and use a new requestId instead > ([here|https://github.com/apache/tinkerpop/blob/master/gremlin-go/driver/request.go#L54]). > All documented per request settings need to be tested and fixed if needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
