[
https://issues.apache.org/jira/browse/TINKERPOP-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676413#comment-17676413
] ASF GitHub Bot commented on TINKERPOP-2847: ------------------------------------------- codecov-commenter commented on PR #1940: URL: https://github.com/apache/tinkerpop/pull/1940#issuecomment-1381261289 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1940](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (868f627) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/b8e6b2827d68bfbc73205df00f201a0e75bd7ca2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8e6b28) will **decrease** coverage by `5.60%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.5-dev #1940 +/- ## ============================================= - Coverage 69.29% 63.69% -5.61% ============================================= Files 865 24 -841 Lines 41086 3680 -37406 Branches 5417 0 -5417 ============================================= - Hits 28472 2344 -26128 + Misses 10696 1159 -9537 + Partials 1918 177 -1741 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...structure/io/graphson/GraphSONSerializersV1d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vZ3JhcGhzb24vR3JhcGhTT05TZXJpYWxpemVyc1YxZDAuamF2YQ==) | | | | [...tructure/io/binary/types/SimpleTypeSerializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vYmluYXJ5L3R5cGVzL1NpbXBsZVR5cGVTZXJpYWxpemVyLmphdmE=) | | | | [...ification/AbstractWarningVerificationStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS92ZXJpZmljYXRpb24vQWJzdHJhY3RXYXJuaW5nVmVyaWZpY2F0aW9uU3RyYXRlZ3kuamF2YQ==) | | | | [...g/apache/tinkerpop/gremlin/jsr223/CoreImports.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9qc3IyMjMvQ29yZUltcG9ydHMuamF2YQ==) | | | | [...remlin/process/traversal/lambda/TrueTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9sYW1iZGEvVHJ1ZVRyYXZlcnNhbC5qYXZh) | | | | [...emlin/process/traversal/step/util/WithOptions.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL3V0aWwvV2l0aE9wdGlvbnMuamF2YQ==) | | | | [...mlin/driver/ser/GraphSONMessageSerializerV1d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9zZXIvR3JhcGhTT05NZXNzYWdlU2VyaWFsaXplclYxZDAuamF2YQ==) | | | | [...ocess/traversal/step/map/TraversalFlatMapStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9UcmF2ZXJzYWxGbGF0TWFwU3RlcC5qYXZh) | | | | [...tinkerpop/gremlin/util/iterator/IteratorUtils.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi91dGlsL2l0ZXJhdG9yL0l0ZXJhdG9yVXRpbHMuamF2YQ==) | | | | [...ucture/io/graphson/AbstractObjectDeserializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vZ3JhcGhzb24vQWJzdHJhY3RPYmplY3REZXNlcmlhbGl6ZXIuamF2YQ==) | | | | ... and [831 more](https://codecov.io/gh/apache/tinkerpop/pull/1940?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > RequestId is case sensitive in JS GLV > ------------------------------------- > > Key: TINKERPOP-2847 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2847 > Project: TinkerPop > Issue Type: Improvement > Components: javascript > Affects Versions: 3.5.5 > Reporter: Cole Greer > Priority: Major > > There is a bug in the javascript GLV where overridden requestID's must be > provided in lowercase form. > For example: > This code will run as expected: > {code:java} > client.submit("g.V()", null, {requestId: > '6457272a-4018-4538-b9ae-08dd5ddc0aa1'}) {code} > But this will never complete. The server replies with an all lower case UUID > which the driver considers distinct from the upper case version. Therefore > the driver acts as if no response is ever received. > {code:java} > client.submit("g.V()", null, {requestId: > '6457272A-4018-4538-B9AE-08DD5DDC0AA1'}) {code} > It appears the JS driver is matching UUID's by checking for exact string > matches, where they should be matched as equal hex values. Exclusively using > lower case request id's is a viable near-term workaround. -- This message was sent by Atlassian Jira (v8.20.10#820010)
