[
https://issues.apache.org/jira/browse/TINKERPOP-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680194#comment-17680194
]
ASF GitHub Bot commented on TINKERPOP-2647:
-------------------------------------------
codecov-commenter commented on PR #1950:
URL: https://github.com/apache/tinkerpop/pull/1950#issuecomment-1401871250
#
[Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1950](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(303874b) into
[master](https://codecov.io/gh/apache/tinkerpop/commit/f9eaf05377657ef93276d3fad662111425381459?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f9eaf05) will **decrease** coverage by `4.35%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1950 +/- ##
============================================
- Coverage 68.61% 64.27% -4.35%
============================================
Files 854 24 -830
Lines 41185 3728 -37457
Branches 5598 0 -5598
============================================
- Hits 28258 2396 -25862
+ Misses 10950 1166 -9784
+ Partials 1977 166 -1811
```
| [Impacted
Files](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...p/gremlin/console/commands/UninstallCommand.groovy](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvY29tbWFuZHMvVW5pbnN0YWxsQ29tbWFuZC5ncm9vdnk=)
| | |
|
[...in/server/handler/WsAndHttpChannelizerHandler.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9oYW5kbGVyL1dzQW5kSHR0cENoYW5uZWxpemVySGFuZGxlci5qYXZh)
| | |
|
[...emlin/process/computer/util/VertexProgramPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3V0aWwvVmVydGV4UHJvZ3JhbVBvb2wuamF2YQ==)
| | |
|
[...ess/traversal/translator/JavascriptTranslator.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC90cmFuc2xhdG9yL0phdmFzY3JpcHRUcmFuc2xhdG9yLmphdmE=)
| | |
|
[...cture/util/star/StarGraphGraphSONDeserializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9zdGFyL1N0YXJHcmFwaEdyYXBoU09ORGVzZXJpYWxpemVyLmphdmE=)
| | |
|
[...mlin/process/traversal/step/map/TailLocalStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9UYWlsTG9jYWxTdGVwLmphdmE=)
| | |
|
[...nkerpop/gremlin/server/util/TraverserIterator.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci91dGlsL1RyYXZlcnNlckl0ZXJhdG9yLmphdmE=)
| | |
|
[...tinkerpop/gremlin/process/traversal/Traversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9UcmF2ZXJzYWwuamF2YQ==)
| | |
|
[...in/process/traversal/lambda/IdentityTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9sYW1iZGEvSWRlbnRpdHlUcmF2ZXJzYWwuamF2YQ==)
| | |
|
[.../gremlin/console/jsr223/GephiRemoteAcceptor.groovy](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvanNyMjIzL0dlcGhpUmVtb3RlQWNjZXB0b3IuZ3Jvb3Z5)
| | |
| ... and [820
more](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> :uninstall without first disabling a plugin will lead to error on startup
> -------------------------------------------------------------------------
>
> Key: TINKERPOP-2647
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2647
> Project: TinkerPop
> Issue Type: Bug
> Components: console
> Affects Versions: 3.4.12
> Reporter: Stephen Mallette
> Priority: Trivial
>
> In the Gremlin Console, if you add a plugin like:
> {code}
> gremlin> :install org.apache.tinkerpop spark-gremlin 3.6.0-SNAPSHOT
> ==>loaded: [org.apache.tinkerpop, spark-gremlin, 3.6.0-SNAPSHOT] - restart
> the console to use [tinkerpop.spark]
> gremlin> :plugin use tinkerpop.spark
> ==>tinkerpop.spark activated
> {code}
> and then you choose to remove it:
> {code}
> gremlin> :uninstall spark-gremlin
> ==>Uninstalled spark-gremlin - restart the console for removal to take effect
> gremlin> :x
> {code}
> When you restart, the console will be in a bad state and produce this sort of
> exception:
> {code}
> $ bin/gremlin.sh
> \,,,/
> (o o)
> -----oOOo-(3)-oOOo-----
> plugin activated: tinkerpop.server
> plugin activated: tinkerpop.utilities
> plugin activated: tinkerpop.tinkergraph
> plugin activated: tinkerpop.spark
> gremlin> :uninstall tinkerpop.spark
> ==>There is no module with the name tinkerpop.spark to remove -
> /home/smallette/git/apache/tinkerpop/gremlin-console/target/apache-tinkerpop-gremlin-console-3.6.0-SNAPSHOT-standalone/ext/tinkerpop.spark
> gremlin> :uninstall spark-gremlin
> ==>Uninstalled spark-gremlin - restart the console for removal to take effect
> gremlin> :x
> smallette@ubuntu-vm:~/git/apache/tinkerpop/gremlin-console/target/apache-tinkerpop-gremlin-console-3.6.0-SNAPSHOT-standalone$
> bin/gremlin.sh
> \,,,/
> (o o)
> -----oOOo-(3)-oOOo-----
> plugin activated: tinkerpop.server
> plugin activated: tinkerpop.utilities
> plugin activated: tinkerpop.tinkergraph
> Exception in thread "main" java.lang.NullPointerException: Cannot invoke
> method activate() on null object
> at
> org.codehaus.groovy.runtime.NullObject.invokeMethod(NullObject.java:91)
> at
> org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:43)
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> at
> org.codehaus.groovy.runtime.callsite.NullCallSite.call(NullCallSite.java:34)
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> at org.apache.tinkerpop.gremlin.console.PluggedIn$activate.call(Unknown
> Source)
> at
> org.apache.tinkerpop.gremlin.console.Console$_closure18.doCall(Console.groovy:149)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101)
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
> at
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:263)
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041)
> at groovy.lang.Closure.call(Closure.java:405)
> at groovy.lang.Closure.call(Closure.java:421)
> at
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2330)
> at
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2315)
> at
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2356)
> at org.codehaus.groovy.runtime.dgm$186.invoke(Unknown Source)
> at
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:244)
> at
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:53)
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
> at
> org.apache.tinkerpop.gremlin.console.Console.<init>(Console.groovy:147)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:80)
> at
> org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:105)
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:237)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:265)
> at org.apache.tinkerpop.gremlin.console.Console.main(Console.groovy:524)
> {code}
> The reason for this issue is that the plugin registration in
> {{ext/plugins.txt}} file is not cleaned up and so the console tries to load
> it on startup. Normally you would {{:plugin unuse tinkerpop:spark}} prior to
> the {{:uninstall}} to make sure the cleanup worked properly.
> To fix this problem, {{:uninstall}} should just remove the registration the
> same way that {{:plugin unuse}} would.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
