Thank you for clarifying my questions Yang. We have the following problems with our release process today: 1. The binaries that we release for python and .Net are not voted-on during the release votes. Hence, there is no way for a user to validate that the binary in PyPi or nuGet is actually generated from the source code that was voted on. 2. The symlink bug that I pointed above will cause problems for folks who download the source code zip and try to run gremlin.sh
Both these problems have been prevalent for earlier releases as well and hence, I don't want to block this release over these gaps. But we should try to fix these problems before the next release. I have created the following JIRA(s) to track these two problems: https://issues.apache.org/jira/browse/TINKERPOP-2860 https://issues.apache.org/jira/browse/TINKERPOP-2861 VOTE +1 (binding) -- Divij Vaidya On Wed, Jan 25, 2023 at 12:01 AM Yang Xia <ya...@bitquilltech.com.invalid> wrote: > Hi Divij, > > Thank you for your feedback! To address your questions: > > 1. I believe that we should probably add UserAgent and the changes in > > connection timeout to the upgrade documentation. They both require user > > side code changes (since they add new configuration or modify the > behaviour > > of existing one) and hence, users must be aware of them while upgrading. > > What do you think? > > > I think it is a valid point to add some information about it in the Upgrade > docs, but perhaps it is something we could add and update post release? It > is a small documentation change that likely should not block release. In > addition, these changes are captured in the CHANGELOG, which is a source of > information users use as well. > > > 2. Apart from the server and the console binary, we are also releasing a > > go-client, python and a .Net client binary as well. Right? Could you > please > > provide links to the client binaries as well so that we can validate the > > signatures on those? > > > For the GLVs, as there are no binaries for gremlin-go (its release is > integrated with GitHub) and no staging of artifacts for other package > managers like Sonatype, any convenience binaries for those languages are > not produced until after the VOTE, when we have agreed to deploy the > official Apache release. > > > 3. The zip binary (apache-tinkerpop-3.5.5-src.zip) has some symbolic links > > that look incorrect (see below). This might require fixing before we > > release. > > > This is an interesting catch. I see the symlinks as relative paths in my > local repository (via ls -la and readlink) and also on GitHub, so I think > it has to do with how maven handles symlinks on macOS when assembling > source files. I’m surprised that bin/validate-distribution.sh did not catch > that. Is there a tool that you used? Perhaps we should update the script to > include symlink checking. > It’s unfortunate we have this small bug but I don’t think it’s bad enough > to warrant redoing both releases, unless we have folks who intend to change > their votes as a result of this find. > > Regards, > > Yang > > *--* > *Yang Xia* > Software Engineer > Bit Quill Technologies Inc. > ya...@bitquilltech.com > https://www.bitquill.com > > This email message is for the sole use of the intended recipient(s) and may > contain confidential and privileged information. Any unauthorized review, > use, disclosure, or distribution is prohibited. If you are not the > intended recipient, please contact the sender by reply email and destroy > all copies of the original message. Thank you. > > > On Tue, Jan 24, 2023 at 2:03 AM Divij Vaidya <divijvaidy...@gmail.com> > wrote: > > > Thank you Yang for taking ownership of this release. > > > > 1. I believe that we should probably add UserAgent and the changes in > > connection timeout to the upgrade documentation. They both require user > > side code changes (since they add new configuration or modify the > behaviour > > of existing one) and hence, users must be aware of them while upgrading. > > What do you think? > > > > 2. Apart from the server and the console binary, we are also releasing a > > go-client, python and a .Net client binary as well. Right? Could you > please > > provide links to the client binaries as well so that we can validate the > > signatures on those? > > > > 3. The zip binary (apache-tinkerpop-3.5.5-src.zip) has some symbolic > links > > that look incorrect (see below). This might require fixing before we > > release. > > > > ``` > > finishing deferred symbolic links: > > tinkerpop-3.5.5/bin/gremlin.sh -> > > > > > /Users/yangx/Repos/maintinkerpop/tinkerpop/./bin/../gremlin-console/bin/gremlin.sh > > tinkerpop-3.5.5/gremlin-console/bin/gremlin.sh -> > > > > > /Users/yangx/Repos/maintinkerpop/tinkerpop/./gremlin-console/bin/../target/apache-tinkerpop-gremlin-console-3.5.5-standalone/bin/gremlin.sh > > ``` > > > > 4. I have verified the following: > > > > 4.1 Download links are valid for server zip and console zip > > 4.2 PGP signatures are valid for server, console and code zip > > 4.3 No new dependencies have been added to server & java client which > > require new license > > > > > > -- > > Divij Vaidya > > > > > > > > On Tue, Jan 24, 2023 at 2:41 AM David Bechberger <d...@bechberger.com> > > wrote: > > > > > VOTE +1 (non-binding) > > > > > > Thanks for getting this release out the door. > > > > > > On Mon, Jan 23, 2023 at 10:29 AM Ken Hu <k...@bitquilltech.com.invalid > > > > > wrote: > > > > > > > Thanks Yang. This looks good to me. > > > > > > > > VOTE +1 (non-binding) > > > > > > > > On Mon, Jan 23, 2023 at 10:04 AM Cole Greer > > > > <cole.gr...@improving.com.invalid> wrote: > > > > > > > > > Thanks for putting this all together Yang. I’ve dug through the > docs > > > and > > > > > artifacts and it all looks good to me. > > > > > > > > > > VOTE +1 (non-binding) > > > > > > > > > > Regards, > > > > > > > > > > Cole Greer > > > > > > > > > > From: Valentyn Kahamlyk <valent...@bitquilltech.com.INVALID> > > > > > Date: Monday, January 23, 2023 at 9:19 AM > > > > > To: dev@tinkerpop.apache.org <dev@tinkerpop.apache.org> > > > > > Subject: Re: [VOTE] TinkerPop 3.5.5 Release > > > > > VOTE +1 (non-binding) > > > > > > > > > > On Fri, Jan 20, 2023 at 7:03 AM Florian Hockmann < > > > f...@florian-hockmann.de > > > > > > > > > > wrote: > > > > > > > > > > > Thanks a lot for taking care of the releases! > > > > > > > > > > > > I checked the links, skimmed over the docs and executed > > > > > > bin/validate-distribution.sh. This failed for me for some reason. > > It > > > > > > complains about a missing Docker image: > > > > > > > > > > > > failed to solve: tinkerpop/gremlin-server:3.5.5: > > > > > > docker.io/tinkerpop/gremlin-server:3.5.5: not found > > > > > > > > > > > > but that only happens during validation of the source > distribution > > > and > > > > is > > > > > > probably specific to my system and not related to this release. > The > > > > other > > > > > > checks also already passed at that point. So, this shouldn't stop > > the > > > > > > release process. > > > > > > > > > > > > My vote is +1. > > > > > > > > > > > > -----Ursprüngliche Nachricht----- > > > > > > Von: Yang Xia <ya...@bitquilltech.com.INVALID> > > > > > > Gesendet: Donnerstag, 19. Januar 2023 23:13 > > > > > > An: dev@tinkerpop.apache.org > > > > > > Betreff: [VOTE] TinkerPop 3.5.5 Release > > > > > > > > > > > > Hello, > > > > > > > > > > > > We are happy to announce that TinkerPop 3.5.5 is ready for > release. > > > > > > > > > > > > The release artifacts can be found at this location: > > > > > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.5.5/ > > > > > > > > > > > > The source distribution is provided by: > > > > > > apache-tinkerpop-3.5.5-src.zip > > > > > > > > > > > > Two binary distributions are provided for user convenience: > > > > > > apache-tinkerpop-gremlin-console-3.5.5-bin.zip > > > > > > apache-tinkerpop-gremlin-server-3.5.5-bin.zip > > > > > > > > > > > > The GPG key used to sign the release artifacts is available at: > > > > > > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > > > > > > > > > > > > The online docs can be found here: > > > > > > https://tinkerpop.apache.org/docs/3.5.5/ (user docs) > > > > > > https://tinkerpop.apache.org/docs/3.5.5/upgrade/ > (upgrade > > > > docs) > > > > > > https://tinkerpop.apache.org/javadocs/3.5.5/core/ (core > > > > javadoc) > > > > > > https://tinkerpop.apache.org/javadocs/3.5.5/full/ (full > > > > javadoc) > > > > > > https://tinkerpop.apache.org/dotnetdocs/3.5.5/ (.NET API > > > docs) > > > > > > https://tinkerpop.apache.org/jsdocs/3.5.5/ (Javascript > API > > > > docs) > > > > > > > > > > > > The Git tag can be found here: > > > > > > https://github.com/apache/tinkerpop/tree/3.5.5 > > > > > > > > > > > > The release notes are available here: > > > > > > > > > > > https://github.com/apache/tinkerpop/blob/3.5.5/CHANGELOG.asciidoc > > > > > > > > > > > > Please note that when you run bin/validate-distribution.sh, you > > might > > > > get > > > > > > "rm: cannot remove" permission errors for some GLV test outputs. > As > > > > this > > > > > > does not affect server/console nor the regular "mvn clean > install" > > > > > > commands, we will not hold the release on that, but have made a > > note > > > to > > > > > > fix after the release. The temporary solution is to run this > script > > > > with > > > > > > sudo or editing the script to add sudo to "rm" commands. > > > > > > > > > > > > The [VOTE] will be open for the next 72 hours --- closing Sunday > > > > (January > > > > > > 22, 2023) at 2:15pm, PST (UTC−08:00). > > > > > > > > > > > > My vote is +1. > > > > > > > > > > > > Thank you very much, > > > > > > > > > > > > Yang Xia > > > > > > > > > > > > *--* > > > > > > *Yang Xia* > > > > > > Software Engineer > > > > > > Bit Quill Technologies Inc. > > > > > > ya...@bitquilltech.com > > > > > > https://www.bitquill.com > > > > > > > > > > > > This email message is for the sole use of the intended > recipient(s) > > > and > > > > > > may contain confidential and privileged information. Any > > > unauthorized > > > > > > review, use, disclosure, or distribution is prohibited. If you > are > > > not > > > > > the > > > > > > intended recipient, please contact the sender by reply email and > > > > destroy > > > > > > all copies of the original message. Thank you. > > > > > > > > > > > > > > > > > > > > > > > > > > >
