[
https://issues.apache.org/jira/browse/TINKERPOP-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684029#comment-17684029
] ASF GitHub Bot commented on TINKERPOP-2865: ------------------------------------------- codecov-commenter commented on PR #1962: URL: https://github.com/apache/tinkerpop/pull/1962#issuecomment-1416392541 # [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1962](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6c5335) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/b8d91efb45ed41d1cd4cd11a7f6e795b5c68a244?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d91ef) will **decrease** coverage by `0.54%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## 3.5-dev #1962 +/- ## ============================================= - Coverage 69.88% 69.35% -0.54% + Complexity 8948 8945 -3 ============================================= Files 841 865 +24 Lines 37412 41160 +3748 Branches 5418 5419 +1 ============================================= + Hits 26144 28545 +2401 - Misses 9532 10697 +1165 - Partials 1736 1918 +182 ``` | [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...aversal/strategy/decoration/PartitionStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9kZWNvcmF0aW9uL1BhcnRpdGlvblN0cmF0ZWd5LmphdmE=) | `83.23% <100.00%> (+0.51%)` | :arrow_up: | | [...cess/computer/traversal/step/map/ShortestPath.java](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9zdGVwL21hcC9TaG9ydGVzdFBhdGguamF2YQ==) | `57.89% <0.00%> (-5.27%)` | :arrow_down: | | [...versal/step/map/ShortestPathVertexProgramStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3RyYXZlcnNhbC9zdGVwL21hcC9TaG9ydGVzdFBhdGhWZXJ0ZXhQcm9ncmFtU3RlcC5qYXZh) | `90.00% <0.00%> (-3.34%)` | :arrow_down: | | [...apache/tinkerpop/gremlin/server/GremlinServer.java](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9HcmVtbGluU2VydmVyLmphdmE=) | `55.60% <0.00%> (-0.49%)` | :arrow_down: | | [...nkerpop/gremlin/groovy/engine/GremlinExecutor.java](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1ncm9vdnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2dyb292eS9lbmdpbmUvR3JlbWxpbkV4ZWN1dG9yLmphdmE=) | `87.28% <0.00%> (-0.43%)` | :arrow_down: | | [...in/process/traversal/dsl/graph/GraphTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9kc2wvZ3JhcGgvR3JhcGhUcmF2ZXJzYWwuamF2YQ==) | `90.81% <0.00%> (-0.37%)` | :arrow_down: | | [gremlin-go/driver/request.go](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvcmVxdWVzdC5nbw==) | `78.89% <0.00%> (ø)` | | | [gremlin-go/driver/connection.go](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvY29ubmVjdGlvbi5nbw==) | `77.77% <0.00%> (ø)` | | | [gremlin-go/driver/authInfo.go](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvYXV0aEluZm8uZ28=) | `83.33% <0.00%> (ø)` | | | [gremlin-go/driver/transporterFactory.go](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvdHJhbnNwb3J0ZXJGYWN0b3J5Lmdv) | `83.33% <0.00%> (ø)` | | | ... and [21 more](https://codecov.io/gh/apache/tinkerpop/pull/1962?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Add has steps injected by PartitionStrategy at the end of the filter > -------------------------------------------------------------------- > > Key: TINKERPOP-2865 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2865 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.5.5 > Reporter: Stephen Mallette > Assignee: Stephen Mallette > Priority: Major > > Currently, {{PartitionStrategy}} will add the {{HasStep}} for the partition > key right after the step that triggers is, like: > {code} > g.V().hasLabel("person") -> g.V().has("_p","A").hasLabel("person") > {code} > It seems better in these cases to be slightly less invasive to the traversal > and push the partition has to the end to therefore preserve the order of the > previous filters: > {code} > g.V().hasLabel("person") -> g.V().hasLabel("person").has("_p","A") > {code} > This change probably matters most to {{Vertex}} and {{Edge}} read steps. -- This message was sent by Atlassian Jira (v8.20.10#820010)
