[
https://issues.apache.org/jira/browse/TINKERPOP-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712079#comment-17712079
]
ASF GitHub Bot commented on TINKERPOP-2890:
-------------------------------------------
spmallette commented on code in PR #2012:
URL: https://github.com/apache/tinkerpop/pull/2012#discussion_r1166015266
##########
gremlin-test/features/filter/Dedup.feature:
##########
@@ -306,4 +306,15 @@ Feature: Step - dedup()
| ripple |
| peter |
| marko |
- | josh |
\ No newline at end of file
+ | josh |
+
+ Scenario: g_injectX1X_dedupXlocalX_unfold
Review Comment:
this was the contrived example from the JIRA, but i think it comes with the
downside that you had to add OptOut for them in computer tests. could you come
up with tests that don't require that OptOut please?
> Avoid exceptions on local scope based steps where possible
> ----------------------------------------------------------
>
> Key: TINKERPOP-2890
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2890
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.5.5
> Reporter: Stephen Mallette
> Priority: Critical
>
> If you {{g.inject([1,2], 1])dedup(local)}} you get an casting error because
> "1" is not an {{Iterable}} and {{local}} only works with that type. Would be
> better if a {{dedup()}} of a non-iterable just returned the object itself.
> Consider other steps that use {{local}} and make similar improvements there
> for consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
