[
https://issues.apache.org/jira/browse/TINKERPOP-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717341#comment-17717341
]
ASF GitHub Bot commented on TINKERPOP-2934:
-------------------------------------------
Cole-Greer commented on PR #2050:
URL: https://github.com/apache/tinkerpop/pull/2050#issuecomment-1526165189
The one question I have about this change is if any users might currently
expect to get the Collections contents to be returned in the toString output.
I'm not too familiar with the use cases here so it might not be a big concern.
Just wondering if there are any potential losses that should be considered.
> Optimize ObjectWritable for displaying content of Java Collection or Map to
> reduce OOM
> --------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2934
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2934
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.6.2
> Reporter: Redriver
> Priority: Major
> Attachments: image-2023-04-27-15-08-10-874.png
>
>
> OLAP query easily triggers OOM, I found a possible reason is
> [https://github.com/apache/tinkerpop/blob/master/hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/structure/io/ObjectWritable.java#L72]
> dump a huge string output. See what I captureed from SparkUI. In fact, that
> toString() does not make much sense for OLAP processing except for displaying
> in UI. Furthermore, those too long string is not readable for people. So,
> ideally the toString() for Map or Collection should be optimized to be java
> class + size(). Then the OOM will disappear.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
