[
https://issues.apache.org/jira/browse/TINKERPOP-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721014#comment-17721014
]
ASF GitHub Bot commented on TINKERPOP-2703:
-------------------------------------------
kenhuuu commented on code in PR #2056:
URL: https://github.com/apache/tinkerpop/pull/2056#discussion_r1188897552
##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java:
##########
@@ -103,9 +103,9 @@ public final class TinkerGraph implements Graph {
protected TinkerIndex<TinkerVertex> vertexIndex = null;
protected TinkerIndex<TinkerEdge> edgeIndex = null;
- protected final IdManager<?> vertexIdManager;
- protected final IdManager<?> edgeIdManager;
- protected final IdManager<?> vertexPropertyIdManager;
+ protected IdManager<?> vertexIdManager;
+ protected IdManager<?> edgeIdManager;
+ protected IdManager<?> vertexPropertyIdManager;
Review Comment:
I tried to explain this in the commit message.
> The final modifier was removed in some TinkerGraph manager fields as these
were removed during testing with reflection. However, as of Java 18 there is no
reasonable way to use reflection to do this. Also, the class is marked final
which should reduce its impact.
Please let me know if you have further concerns about this.
> Build on JDK17
> --------------
>
> Key: TINKERPOP-2703
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2703
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
> Affects Versions: 3.5.2
> Reporter: Stephen Mallette
> Priority: Minor
>
> Upgrade the build to work with JDK17. This actually is a bit of an umbrella
> issue covering lots of different things in TinkerPop. Early examination of
> this issue shows that like the move to JDK11, the change is not trivial.
> Known issues so far:
> * Groovy 4.x upgrade brings some strange failures to the gmavenplus-plugin
> during GLV building
> * Kryo 3.x is not compliant with JDK17
> In addition, Please look at the related linked issues for more information.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
