[ 
https://issues.apache.org/jira/browse/TINKERPOP-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776376#comment-17776376
 ] 

ASF GitHub Bot commented on TINKERPOP-2999:
-------------------------------------------

codecov-commenter commented on PR #2297:
URL: https://github.com/apache/tinkerpop/pull/2297#issuecomment-1767100258

   ## 
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2297?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   > Merging 
[#2297](https://app.codecov.io/gh/apache/tinkerpop/pull/2297?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 (5a9c02f) into 
[master](https://app.codecov.io/gh/apache/tinkerpop/commit/b110ffe88e898e056f025c7fd1f167cf3a0bf7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 (b110ffe) will **decrease** coverage by `4.70%`.
   > Report is 11 commits behind head on master.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2297      +/-   ##
   ============================================
   - Coverage     75.81%   71.11%   -4.70%     
   ============================================
     Files          1062       25    -1037     
     Lines         64393     3895   -60498     
     Branches       7115        0    -7115     
   ============================================
   - Hits          48819     2770   -46049     
   + Misses        12931      934   -11997     
   + Partials       2643      191    -2452     
   ```
   
   
   [see 1037 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2297/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   




> 3.7.0 Remote Console Sends Incomplete Queries
> ---------------------------------------------
>
>                 Key: TINKERPOP-2999
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2999
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: console
>    Affects Versions: 3.7.0
>            Reporter: Ken Hu
>            Priority: Critical
>
> As reported by user "pdsway" on gremlin-users.
> In remote console mode the 3.7.0 Gremlin Console will send incomplete queries 
> to the server causing a parsing error.
> This is caused by the upgrade to Groovy 4. That version of Groovy uses the 
> newer antlr4 parser which throws errors later in execution. So even if the 
> parser says the the line is COMPLETE, it could still be incomplete. We need 
> to add the same try catch to the remote console's execution to make the 
> handling the same as groovysh.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to