[ https://issues.apache.org/jira/browse/TINKERPOP-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781896#comment-17781896 ]
ASF GitHub Bot commented on TINKERPOP-3009: ------------------------------------------- codecov-commenter commented on PR #2322: URL: https://github.com/apache/tinkerpop/pull/2322#issuecomment-1789698764 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2322?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2322](https://app.codecov.io/gh/apache/tinkerpop/pull/2322?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0b69291) into [3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/3f1f28df102b151bc62cadd83c3cee8b154236df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3f1f28d) will **decrease** coverage by `3.97%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.6-dev #2322 +/- ## ============================================= - Coverage 75.15% 71.18% -3.97% ============================================= Files 1056 25 -1031 Lines 63371 3766 -59605 Branches 6924 0 -6924 ============================================= - Hits 47628 2681 -44947 + Misses 13179 898 -12281 + Partials 2564 187 -2377 ``` [see 1031 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2322/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > SubgraphStrategy produces excessive filtering when multiple labels are > filtered upon > ------------------------------------------------------------------------------------ > > Key: TINKERPOP-3009 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3009 > Project: TinkerPop > Issue Type: Bug > Components: process > Affects Versions: 3.6.2 > Reporter: Brian O'Keefe > Priority: Critical > > See the example profile below. Notice the traversal includes _has _filters > everywhere repeatedly applied for vertices which are already filtered before > too. > {noformat} > gremlin> g.withStrategies(SubgraphStrategy.build(). > ......1> vertices(hasLabel('x','y','z')).create()). > ......2> V().out().profile() > ==>Traversal Metrics > Step Count > Traversers Time (ms) % Dur > ============================================================================================================= > TinkerGraphStep(vertex,[~label.within([x, y, z])]) > 0.160 58.50 > VertexStep(OUT,edge) > 0.017 6.53 > AndStep([[EdgeVertexStep(IN), HasStep([~label.w... > 0.017 6.19 > EdgeVertexStep(IN) > 0.000 > HasStep([~label.within([x, y, z])]) > 0.000 > EdgeVertexStep(OUT) > 0.000 > HasStep([~label.within([x, y, z])]) > 0.000 > EdgeVertexStep(IN) > 0.064 23.59 > HasStep([~label.within([x, y, z])]) > 0.014 5.18 > >TOTAL - > - 0.274 - > {noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)