[
https://issues.apache.org/jira/browse/TINKERPOP-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789545#comment-17789545
]
ASF GitHub Bot commented on TINKERPOP-2913:
-------------------------------------------
codecov-commenter commented on PR #2364:
URL: https://github.com/apache/tinkerpop/pull/2364#issuecomment-1826013869
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2364?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base
[(`a9ff025`)](https://app.codecov.io/gh/apache/tinkerpop/commit/a9ff025c8319330bf51c5c7df562f7f2d7a260a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
75.20% compared to head
[(`a7245bc`)](https://app.codecov.io/gh/apache/tinkerpop/pull/2364?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
71.23%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.6-dev #2364 +/- ##
=============================================
- Coverage 75.20% 71.23% -3.97%
=============================================
Files 1057 25 -1032
Lines 63450 3772 -59678
Branches 6935 0 -6935
=============================================
- Hits 47716 2687 -45029
+ Misses 13169 898 -12271
+ Partials 2565 187 -2378
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2364?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Ensure that if tx.commit() is called remotely it does not hang for graphs
> without transactions
> ----------------------------------------------------------------------------------------------
>
> Key: TINKERPOP-2913
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2913
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet, go, javascript, python
> Affects Versions: 3.5.5
> Reporter: Stephen Mallette
> Priority: Critical
>
> Javascript has been reported to hang if you do a {{tx.commit()}} and the
> remote graph does not support transactions (i.e. TinkerGraph). It should
> return an exception similar to how Java does:
> {code}
> gremlin> tx.commit()
> Transaction commit for Optional.empty failed
> Type ':help' or ':h' for help.
> Display stack trace? [yN]y
> ....
> Caused by: java.util.concurrent.CompletionException:
> org.apache.tinkerpop.gremlin.driver.exception.ResponseException: Graph does
> not support transactions
> at
> java.util.concurrent.CompletableFuture.reportJoin(CompletableFuture.java:375)
> at
> java.util.concurrent.CompletableFuture.join(CompletableFuture.java:1947)
> at org.apache.tinkerpop.gremlin.driver.ResultSet.one(ResultSet.java:123)
> at
> org.apache.tinkerpop.gremlin.driver.ResultSet$1.hasNext(ResultSet.java:175)
> at
> org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteTraversal$TraverserIterator.hasNext(DriverRemoteTraversal.java:110)
> at
> org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteTraversal.hasNext(DriverRemoteTraversal.java:70)
> at
> org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteTransaction.closeRemoteTransaction(DriverRemoteTransaction.java:95)
> ... 70 more
> Caused by: org.apache.tinkerpop.gremlin.driver.exception.ResponseException:
> Graph does not support transactions
> at
> org.apache.tinkerpop.gremlin.driver.Handler$GremlinResponseHandler.channelRead0(Handler.java:245)
> at
> org.apache.tinkerpop.gremlin.driver.Handler$GremlinResponseHandler.channelRead0(Handler.java:200)
> at ....
> {code}
> Check all non-java drivers and provide tests to enforce the appropriate
> behavior. It would be worth examining behavior of all {{tx}} methods like
> {{rollback()}} and {{close()}} as well. can this be somehow part of the
> gherkin test suite rather than one-off tests?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
