[ 
https://issues.apache.org/jira/browse/TINKERPOP-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813633#comment-17813633
 ] 

ASF GitHub Bot commented on TINKERPOP-3045:
-------------------------------------------

spmallette commented on code in PR #2475:
URL: https://github.com/apache/tinkerpop/pull/2475#discussion_r1475959778


##########
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/Range.feature:
##########
@@ -280,4 +280,16 @@ Feature: Step - range()
     When iterated to list
     Then the result should be unordered
       | result |
-      | d[29].i |
\ No newline at end of file
+      | d[29].i |
+
+  Scenario: g_V_mapXinX_limitX2X_valuesXnameX
+    Given the modern graph
+    And the traversal of
+      """
+      g.V().map(__.in()).limit(2).values('name')

Review Comment:
   nit: we prefer double quotes for strings in our feature tests as a 
convention. 





> EarlyLimitStrategy is too aggresive to promote Limit and thus causing 
> incorrect results
> ---------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-3045
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3045
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.6.6
>         Environment: ALL
>            Reporter: Prashant
>            Priority: Major
>              Labels: easyfix
>             Fix For: 3.6.7
>
>
> {code:java}
> gremlin>   g.V().map(__.in().hasId('1')).limit(2).values('name')
> ==>marko{code}
> {code:java}
> gremlin>   
> g.withoutStrategies(EarlyLimitStrategy).V().map(__.in().hasId('1')).limit(2).values('name')
> ==>marko
> ==>marko {code}
> Early Limit strategy pulls Limit in front of map steps. However not all map 
> steps allow the cardinality of the results flowing to be same. 
>  
> As is shown in example above.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to