[ 
https://issues.apache.org/jira/browse/TINKERPOP-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835417#comment-17835417
 ] 

ASF GitHub Bot commented on TINKERPOP-3060:
-------------------------------------------

HappyHacker123 commented on PR #2546:
URL: https://github.com/apache/tinkerpop/pull/2546#issuecomment-2045162964

   Thanks for your response :) @xiazcy . 
   > Note that we are in the middle of a release so we'll hold off on any 
merging and I'll revisit this PR once the release is done.
   Sure, I'm fully supportive of holding off the pr until after the release is 
completed :).
   > I do want to take a closer look into other pom files that might be able to 
take advantage of this.
   Actually i ran a check on the whole Tinkerpop project and found many other 
situation like this. If you need it, i'm happy to provide the whole list :).




> Dependency inconsistency between modules.
> -----------------------------------------
>
>                 Key: TINKERPOP-3060
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3060
>             Project: TinkerPop
>          Issue Type: Improvement
>            Reporter: Wei Zhao
>            Priority: Major
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> h3. Problem Desciption
> Currently some modules of Tinkerpop are using the same dependency. However, 
> some of these dependencies' versions are not centrally managed and therefore 
> cause discrepancy.
> I found the following dependencies with different versions in different 
> modules.
> {code:java}
> Dependency org.xerial.snappy:snappy-java:jar has inconsistent versions.
>     Dependency {groupId=org.xerial.snappy, artifactId=snappy-java, 
> version=1.1.8.4}
>         /spark-gremlin
>     Dependency {groupId=org.xerial.snappy, artifactId=snappy-java, 
> version=1.1.8.2}
>         /hadoop-gremlin
> ---------
> Dependency com.fasterxml.jackson.core:jackson-databind:jar has inconsistent 
> versions.
>     Dependency {groupId=com.fasterxml.jackson.core, 
> artifactId=jackson-databind, version=2.15.2}
>         /gremlin-shaded
>     Dependency {groupId=com.fasterxml.jackson.core, 
> artifactId=jackson-databind, version=2.13.5}
>         /spark-gremlin
>         /hadoop-gremlin
> ---------
> {code}
> h3. Possible Outcome:
> This increases the maintenance workload and may lead to dependency conflict 
> for downstream projects. So it's better to align the versions of the 
> dependencies if the discrepancy is not intentional.
> h3. Possible Solution
> Align the versions of the dependencies to ensure consistency and avoid 
> possible conflicts. And if it's possible, manage the versions of the 
> dependencies centrally.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to