Thank you for noticing that Cole. I definitely missed it in my review. Yes, unfortunately this does mean that anyone intending to build the console from the source will need to create their own convenience symlinks, or run bin/gremlin.sh from the target folder directly. Though I would agree that this is minor enough to not warrant a re-vote, as it doesn't affect the console directly and the most prevalent use of the console is through the distribution zip, which is working as intended. It does appear that we have encountered similar issues in the past where we released source with broken symlinks due to assembly plugin issues. Going forward it's definitely good to add additional symlink checking into validate-distribution.sh. I will also add a step in the docs for manually checking them after staging the release. Another direction to consider is to replace the use of these symlinks with actual scripts, like how the gremlin.bat files are written, to avoid potential issues that come with symlinks for future releases.
Thanks, Yang On Fri, Apr 12, 2024 at 5:01 PM Cole Greer <cole.gr...@improving.com.invalid> wrote: > I scanned through the docs and ran validate-distribution.sh. I did notice > one minor issue in that the bin/gremlin.sh symlinks are missing. The > symlinks are just a minor convenience for people directly using the source > distribution, and I don’t think they are widely used. I don’t see this as a > release blocker. Everything else looks good to me. > > VOTE +1 (non-binding) > > Thanks, > > Cole > > On 2024/04/10 17:58:13 Kelvin Lawrence wrote: > > I downloaded the binary, ran the console, loaded data, ran some queries. > LGTM > > > > VOTE +1 > > > > Kelvin > > > > > > > > > > On Wednesday, April 10, 2024 at 09:46:52 AM CDT, Florian Hockmann < > fh...@florian-hockmann.de<mailto:fh...@florian-hockmann.de>> wrote: > > > > I checked the links and skimmed over the docs. Everything looks good to > me. > > > > VOTE +1 > > > > -----Ursprüngliche Nachricht----- > > Von: Yang Xia <ya...@bitquilltech.com.inva<mailto: > ya...@bitquilltech.com.inva>LID> > > Gesendet: Mittwoch, 10. April 2024 14:37 > > An: dev@tinkerpop.apache.org<mailto:dev@tinkerpop.apache.org> > > Betreff: [VOTE] TinkerPop 3.7.2 Release > > > > Hello, > > > > We are happy to announce that TinkerPop 3.7.2 is ready for release. > > > > The release artifacts can be found at this location: > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.7.2/ > > > > The source distribution is provided by: > > apache-tinkerpop-3.7.2-src.zip > > > > Two binary distributions are provided for user convenience: > > apache-tinkerpop-gremlin-console-3.7.2-bin.zip > > apache-tinkerpop-gremlin-server-3.7.2-bin.zip > > > > The GPG key used to sign the release artifacts is available at: > > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > > > > The online docs can be found here: > > https://tinkerpop.apache.org/docs/3.7.2/ (user docs) > > https://tinkerpop.apache.org/docs/3.7.2/upgrade/ (upgrade docs) > > https://tinkerpop.apache.org/javadocs/3.7.2/core/ (core javadoc) > > https://tinkerpop.apache.org/javadocs/3.7.2/full/ (full javadoc) > > https://tinkerpop.apache.org/dotnetdocs/3.7.2/ (.NET API docs) > > https://tinkerpop.apache.org/jsdocs/3.7.2/ (Javascript API docs) > > > > The Git tag can be found here: > > https://github.com/apache/tinkerpop/tree/3.7.2 > > > > The release notes are available here: > > > https://github.com/apache/tinkerpop/blob/3.7.2/CHANGELOG.asciidoc > > > > The [VOTE] will be open for the next 72 hours --- closing Saturday > (April 13, 2024) at 5:45am PT (UTC−08:00). > > > > My vote is +1. > > > > Thank you very much, > > > > Yang > > *--* > > *Yang Xia* > > > > >
