[ 
https://issues.apache.org/jira/browse/TINKERPOP-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852737#comment-17852737
 ] 

ASF GitHub Bot commented on TINKERPOP-3028:
-------------------------------------------

spmallette commented on code in PR #2640:
URL: https://github.com/apache/tinkerpop/pull/2640#discussion_r1629336861


##########
gremlin-python/src/main/python/gremlin_python/process/graph_traversal.py:
##########
@@ -1424,6 +1428,10 @@ def ltrim(cls, *args):
     def l_trim(cls, *args):
         return cls.graph_traversal(None, None, Bytecode()).l_trim(*args)
 
+    @classmethod

Review Comment:
   thanks for noticing that.





> Convert translators to make use of the grammar
> ----------------------------------------------
>
>                 Key: TINKERPOP-3028
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3028
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: translator
>    Affects Versions: 3.6.6
>            Reporter: Stephen Mallette
>            Assignee: Stephen Mallette
>            Priority: Major
>
> {{Translator}} infrastructure uses bytecode and reflection which has a number 
> of technical imperfections and exemptions for it to work properly. Switching 
> to the grammar for translation simplifies the code, removes friction and 
> complexity when generating GLV tests, and should perform better. The focus 
> for this issue is the Java series of translators which are relied on quite 
> heavily. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to