[
https://issues.apache.org/jira/browse/TINKERPOP-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17891810#comment-17891810
]
ASF GitHub Bot commented on TINKERPOP-3116:
-------------------------------------------
codecov-commenter commented on PR #2844:
URL: https://github.com/apache/tinkerpop/pull/2844#issuecomment-2428985460
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2844?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 75.42%. Comparing base
[(`d9e34fb`)](https://app.codecov.io/gh/apache/tinkerpop/commit/d9e34fb4678c29ffa167066de45a9fa7329a319a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`707ec70`)](https://app.codecov.io/gh/apache/tinkerpop/commit/707ec707de104d4736d0c75425106eafb676dae3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 136 commits behind head on 3.6-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.6-dev #2844 +/- ##
=============================================
+ Coverage 75.14% 75.42% +0.27%
- Complexity 12346 12371 +25
=============================================
Files 1058 1033 -25
Lines 63610 59912 -3698
Branches 6962 6976 +14
=============================================
- Hits 47801 45189 -2612
+ Misses 13225 12328 -897
+ Partials 2584 2395 -189
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2844?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> async_timeout not declared in gremlinpython dependencies
> --------------------------------------------------------
>
> Key: TINKERPOP-3116
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3116
> Project: TinkerPop
> Issue Type: Bug
> Components: python
> Affects Versions: 3.7.2
> Reporter: Jon Zeolla
> Priority: Minor
>
> `async-timeout` is missing from [the install
> requirements|https://github.com/apache/tinkerpop/blob/49829884a5617ed1a86211e69826c16e549b0600/gremlin-python/src/main/python/setup.py#L47-L52].
> This appears to have been untouched for quite a while; possibly some
> upstream dependency no longer uses `async-timeout`?
> `async-timeout` _is_ installed [in the
> example|https://github.com/apache/tinkerpop/blob/49829884a5617ed1a86211e69826c16e549b0600/gremlin-python/src/main/python/examples/requirements.txt#L21]
> and after I do a fresh install of `gremlinpython` I saw the following:
> ```bash
> ➜ python3
> Python 3.12.6 (main, Sep 9 2024, 21:36:32) [Clang 18.1.8 ] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> from gremlin_python.process.anonymous_traversal import traversal
> >>> from gremlin_python.driver.driver_remote_connection import
> >>> DriverRemoteConnection
> >>> g =
> >>> traversal().with_remote(DriverRemoteConnection('ws://localhost:8182/gremlin','g'))
> Traceback (most recent call last):
> File
> "/Users/example/tinkerpop/.venv/lib/python3.12/site-packages/gremlin_python/driver/client.py",
> line 70, in __init__
> from gremlin_python.driver.aiohttp.transport import (
> File
> "/Users/example/tinkerpop/.venv/lib/python3.12/site-packages/gremlin_python/driver/aiohttp/transport.py",
> line 21, in <module>
> import async_timeout
> ModuleNotFoundError: No module named 'async_timeout'
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File "<stdin>", line 1, in <module>
> File
> "/Users/example/tinkerpop/.venv/lib/python3.12/site-packages/gremlin_python/driver/driver_remote_connection.py",
> line 69, in __init__
> self._client = client.Client(url, traversal_source,
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File
> "/Users/example/tinkerpop/.venv/lib/python3.12/site-packages/gremlin_python/driver/client.py",
> line 73, in __init__
> raise Exception("Please install AIOHTTP or pass "
> ```
> After installing `async-timeout` I now get:
> ```bash
> ➜ python3
> Python 3.12.6 (main, Sep 9 2024, 21:36:32) [Clang 18.1.8 ] on darwin
> Type "help", "copyright", "credits" or "license" for more information.
> >>> from gremlin_python.process.anonymous_traversal import traversal
> >>> from gremlin_python.driver.driver_remote_connection import
> >>> DriverRemoteConnection
> >>>
> >>> g =
> >>> traversal().with_remote(DriverRemoteConnection('ws://localhost:8182/gremlin',
> >>> 'g'))
> ```
> h2. My environment
> macOS 15.0.1, M2
> Python 3.12.6
> gremlin_python 3.7.2
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
