[ 
https://issues.apache.org/jira/browse/TINKERPOP-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910844#comment-17910844
 ] 

ASF GitHub Bot commented on TINKERPOP-3124:
-------------------------------------------

kenhuuu commented on code in PR #2964:
URL: https://github.com/apache/tinkerpop/pull/2964#discussion_r1906171115


##########
docs/src/reference/gremlin-applications.asciidoc:
##########
@@ -1273,22 +1274,27 @@ NOTE: Installing Ganglia will include 
`org.acplt:oncrpc`, which is an LGPL licen
 Regardless of the output, the metrics gathered are the same. Each metric is 
prefixed with
 `org.apache.tinkerpop.gremlin.server.GremlinServer` and the following metrics 
are reported:
 
-* `sessions` - The number of sessions open at the time the metric was last 
measured. For the `UnifiedChannelizer`, each
-request creates a "session", even a so-called "sessionless request", which is 
basically a session that will only
-execute within the context of that single request.
+* `channels.paused` - The current number of open channels (HTTP and Websocket) 
that are have their writes to buffer

Review Comment:
   ```suggestion
   * `channels.paused` - The current number of open channels (HTTP and 
WebSocket) that have their writes to buffer
   ```





> MessageSizeEstimator is not sizing Frame instances properly
> -----------------------------------------------------------
>
>                 Key: TINKERPOP-3124
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3124
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.7.3
>            Reporter: Stephen Mallette
>            Assignee: Stephen Mallette
>            Priority: Critical
>
> Netty has a {{MessageSizeEstimator}} which helps estimate the number of bytes 
> in the channel's direct memory buffer. Each channel checks the count against 
> the {{writeBufferHighWaterMark}} to determine if writes should be paused to 
> avoid OOMs. The default implementation of the estimator from Netty does not 
> take {{Frame}} into account and therefore the estimations are off.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to