[
https://issues.apache.org/jira/browse/TINKERPOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923867#comment-17923867
]
ASF GitHub Bot commented on TINKERPOP-3070:
-------------------------------------------
kenhuuu commented on code in PR #3012:
URL: https://github.com/apache/tinkerpop/pull/3012#discussion_r1942066247
##########
CHANGELOG.asciidoc:
##########
@@ -31,6 +31,7 @@
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
* Changed Gremlin grammar to make use of `g` to spawn child traversals a
syntax error.
* Added `unexpected-response` handler to `ws` for `gremlin-javascript`
* Fixed bug in `TinkerTransactionGraph` where a read-only transaction may
leave elements trapped in a "zombie transaction".
+* Added quotations in 'gremlin.sh' to accept directories with spaces in the
name
Review Comment:
```suggestion
* Fixed bug in `gremlin.sh` where it couldn't accept a directory name
containing spaces.
```
In general, you want to explain what you fixed, not what you did.
> Cannot run console if working directory contains spaces
> -------------------------------------------------------
>
> Key: TINKERPOP-3070
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3070
> Project: TinkerPop
> Issue Type: Improvement
> Components: console
> Affects Versions: 3.7.1
> Reporter: Cole Greer
> Priority: Critical
>
> If the current working directory contains spaces, gremlin.sh does not handle
> it properly when launching the console, and the JVM will search for an
> incorrect main class and fail.
> For example if I simply rename the standard console distribution directory to
> `{{foo bar}}`:
> {code:bash}
> foo bar/ $ bin/gremlin.sh
>
>
>
> Error: Could not find or load main class bar
> Caused by: java.lang.ClassNotFoundException: bar
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
