[
https://issues.apache.org/jira/browse/TINKERPOP-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928212#comment-17928212
]
ASF GitHub Bot commented on TINKERPOP-2966:
-------------------------------------------
andreachild commented on code in PR #3039:
URL: https://github.com/apache/tinkerpop/pull/3039#discussion_r1960660296
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/translator/PythonTranslator.java:
##########
@@ -443,10 +443,6 @@ static final class SymbolHelper {
TO_PYTHON_MAP.put("and", "and_");
TO_PYTHON_MAP.put("any", "any_");
TO_PYTHON_MAP.put("as", "as_");
- TO_PYTHON_MAP.put("asString", "as_string");
Review Comment:
Ideally there would be unit test coverage in the `PythonTranslatorTest` to
check each of these removals didn't break the translator functionality.
> Change PythonTranslator to generate underscore based step naming
> ----------------------------------------------------------------
>
> Key: TINKERPOP-2966
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2966
> Project: TinkerPop
> Issue Type: Improvement
> Components: translator
> Affects Versions: 3.5.6
> Reporter: Stephen Mallette
> Priority: Minor
>
> The more idiomatic underscore based step naming was introduced a long time
> ago but the {{PythonTranslator}}} still produces the old camelcase style.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
