[ 
https://issues.apache.org/jira/browse/TINKERPOP-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933668#comment-17933668
 ] 

ASF GitHub Bot commented on TINKERPOP-3015:
-------------------------------------------

vkagamlyk commented on PR #3068:
URL: https://github.com/apache/tinkerpop/pull/3068#issuecomment-2709106684

   VOTE +1




> Use wildcard instead of Object for hasId predicates
> ---------------------------------------------------
>
>                 Key: TINKERPOP-3015
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3015
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.5.7, 3.6.5
>            Reporter: Christopher Smith
>            Priority: Minor
>
> From both {{GraphTraversal}} and {{__}}, the {{hasId(P)}} steps specify a 
> {{P<Object>}}. Common predicates, such as {{within}}, propagate the generic 
> type from their own arguments, so that this produces a compile-time error:
> {code}
> Collection<String> ids = ...
> g.V().hasId(P.within(ids))
> {code}
> I believe that without loss of safety, the signature in both locations could 
> be changed to {{P<?>}}, making the typical case of "here's a collection of 
> IDs of known type" work smoothly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to