[ 
https://issues.apache.org/jira/browse/TINKERPOP-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942083#comment-17942083
 ] 

ASF GitHub Bot commented on TINKERPOP-3047:
-------------------------------------------

kenhuuu commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2034469182


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java:
##########
@@ -34,6 +34,7 @@
 import org.apache.tinkerpop.gremlin.structure.T;
 import org.apache.tinkerpop.gremlin.structure.Vertex;
 import org.apache.tinkerpop.gremlin.structure.VertexProperty;
+import 
org.apache.tinkerpop.gremlin.structure.io.gryo.kryoshim.shaded.ShadedOutputAdapter;

Review Comment:
   Is this import actually used?





> Grammar does not parse keywords into Map keys
> ---------------------------------------------
>
>                 Key: TINKERPOP-3047
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3047
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: language
>    Affects Versions: 3.7.1
>            Reporter: Stephen Mallette
>            Priority: Critical
>
> {{[keys: ["a","b"]}} won't work because "keys" ends up being parsed to 
> {{Column.keys}}. another issue at play is the use of parens to wrap certain 
> key definitions but not others. it doesn't feel consistent. like, it will 
> work for {{T}} values but not for something like "edges" which is just a 
> keyword token. Not sure it's wrong but it requires some examination.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to