[
https://issues.apache.org/jira/browse/TINKERPOP-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943699#comment-17943699
]
ASF GitHub Bot commented on TINKERPOP-3150:
-------------------------------------------
codecov-commenter commented on PR #3093:
URL: https://github.com/apache/tinkerpop/pull/3093#issuecomment-2798145115
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3093?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for
BASE (`3.8-dev@619e1f7`). [Learn
more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit)
about missing BASE report.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.8-dev #3093 +/- ##
==========================================
Coverage ? 74.94%
==========================================
Files ? 28
Lines ? 6139
Branches ? 0
==========================================
Hits ? 4601
Misses ? 1330
Partials ? 208
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3093?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Prevent sample step from having multiple by modulators
> ------------------------------------------------------
>
> Key: TINKERPOP-3150
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3150
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.3
> Reporter: Andrea C
> Priority: Minor
>
> Sample step will ignore previous by modulators if multiple are specified,
> which can be misleading to the user. Instead, similar to
> https://issues.apache.org/jira/browse/TINKERPOP-3121 multiple by modulators
> should be prevented with sample.
> {code:java}
> gremlin> g.V().sample(10).by(id).elementMap()
> ==>[id:1,label:person,name:marko,age:29]
> ==>[id:2,label:person,name:vadas,age:27]
> ==>[id:3,label:software,name:lop,lang:java]
> ==>[id:4,label:person,name:josh,age:32]
> ==>[id:5,label:software,name:ripple,lang:java]
> ==>[id:6,label:person,name:peter,age:35]
> gremlin> g.V().sample(10).by('age').elementMap()
> ==>[id:1,label:person,name:marko,age:29]
> ==>[id:2,label:person,name:vadas,age:27]
> ==>[id:4,label:person,name:josh,age:32]
> ==>[id:6,label:person,name:peter,age:35]
> gremlin> g.V().sample(10).by('age').by(id).elementMap()
> ==>[id:1,label:person,name:marko,age:29]
> ==>[id:2,label:person,name:vadas,age:27]
> ==>[id:3,label:software,name:lop,lang:java]
> ==>[id:4,label:person,name:josh,age:32]
> ==>[id:5,label:software,name:ripple,lang:java]
> ==>[id:6,label:person,name:peter,age:35]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
