[
https://issues.apache.org/jira/browse/TINKERPOP-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949104#comment-17949104
]
ASF GitHub Bot commented on TINKERPOP-3147:
-------------------------------------------
Cole-Greer commented on code in PR #3113:
URL: https://github.com/apache/tinkerpop/pull/3113#discussion_r2072234030
##########
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/Sample.feature:
##########
@@ -18,6 +18,24 @@
@StepClassFilter @StepSample
Feature: Step - sample()
+ Scenario: g_V_aggregateXxX_byXnameX_byXageX_capXxX
Review Comment:
Nit: Move these tests to Aggregate.feature
> Prevent aggregate step from having multiple by modulators
> ---------------------------------------------------------
>
> Key: TINKERPOP-3147
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3147
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.3
> Reporter: Andrea C
> Priority: Minor
>
> Aggregate step will ignore previous by modulators if multiple are specified,
> which can be misleading to the user. Instead, similar to
> https://issues.apache.org/jira/browse/TINKERPOP-3121 multiple by modulators
> should be prevented with aggregate.
> {code:java}
> gremlin> g.V().aggregate('x').by('name').cap('x')
> ==>[marko,vadas,lop,josh,ripple,peter]
> gremlin> g.V().aggregate('x').by('name').by('age').cap('x')
> ==>[29,27,32,35] {code}
>
> Note that `store` step is an alias to `aggregate` and should also be
> prevented from having multiple by modulators.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
