[ https://issues.apache.org/jira/browse/TINKERPOP-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18008146#comment-18008146 ]
ASF GitHub Bot commented on TINKERPOP-3141: ------------------------------------------- vkagamlyk commented on code in PR #3161: URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216833048 ########## tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraphTest.java: ########## @@ -1503,4 +1504,53 @@ public void shouldHandleCorrectlyHandleCountForChangedAndReadElement() { assertFalse(vertex.inUse()); } + + @Test + public void shouldAllowDropThenInsertInSameTransaction() { Review Comment: test scenarios that can be considered for reliability: - add and remove vertex with same ID in single transaction. It can be 4 tests, combinations like add-remove-add, add-remove-add-remove, remove-add-remove-add, remove-add-remove. Existing tests covers only cases like add-remove, for example `shouldDeleteCreatedVertexOnCommit` - some multi-threaded test case, like remove-add in main thread (without commit) and remove-add-remove in another thread. Example of similar test is `shouldDeleteUnusedVertexContainerOnConcurrentVertexDelete` > TinkerTransactionGraph doesn't allow deleting and adding element back in same > transaction > ----------------------------------------------------------------------------------------- > > Key: TINKERPOP-3141 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3141 > Project: TinkerPop > Issue Type: Bug > Components: tinkergraph > Affects Versions: 3.7.3 > Reporter: Ken Hu > Priority: Critical > > Originally discovered from: > https://stackoverflow.com/questions/79467860/issue-with-transactions-in-local-tinkerpop-gremlin-setup > [https://groups.google.com/g/gremlin-users/c/NRwb4xy2eXs] > > An element with the same Id cannot be dropped and then added back in the same > transaction. > > {code:java} > @Test > public void shouldAllowDropThenInsert() throws InterruptedException { > final TinkerTransactionGraph g = TinkerTransactionGraph.open(); > final GraphTraversalSource gtx = g.tx().begin(); > gtx.addV().property(T.id, 1).next(); > gtx.tx().commit(); > GraphTraversalSource gtx2 = g.tx().begin(); > gtx2.V().drop().iterate(); > gtx.addV().property(T.id, 1).next(); > gtx2.tx().commit(); > assertEquals(1, g.getVertices().size()); > } {code} > throws a TransactionException. > This occurs when the transaction attempts to get updated, the old > vertex"isDeletedInTx" but has a different txNumber than the newly created > vertex. > [https://github.com/apache/tinkerpop/blob/3.7.3/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerElementContainer.java#L185] > should probably allow this case through. > -- This message was sent by Atlassian Jira (v8.20.10#820010)