[ https://issues.apache.org/jira/browse/TINKERPOP-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018009#comment-18018009 ]
ASF GitHub Bot commented on TINKERPOP-3173: ------------------------------------------- xiazcy commented on code in PR #3195: URL: https://github.com/apache/tinkerpop/pull/3195#discussion_r2320496742 ########## gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/PTest.java: ########## @@ -22,6 +22,7 @@ import org.apache.tinkerpop.gremlin.process.traversal.step.GValue; import org.apache.tinkerpop.gremlin.process.traversal.util.AndP; import org.apache.tinkerpop.gremlin.process.traversal.util.OrP; +import org.apache.tinkerpop.gremlin.util.GremlinValueComparator; Review Comment: nit: unused > Simplify Comparability Semantics > -------------------------------- > > Key: TINKERPOP-3173 > URL: https://issues.apache.org/jira/browse/TINKERPOP-3173 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.7.3 > Reporter: Cole Greer > Priority: Major > > As recently discussed on the > [devlist|https://lists.apache.org/thread/hsqw2tvc72dw4z40nnbbdmygrqx43syr], > our current system of ternary boolean logic should be simplified to binary > boolean logic where invalid comparisons simply return false. -- This message was sent by Atlassian Jira (v8.20.10#820010)