[
https://issues.apache.org/jira/browse/TINKERPOP-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018728#comment-18018728
]
ASF GitHub Bot commented on TINKERPOP-3173:
-------------------------------------------
vkagamlyk commented on code in PR #3195:
URL: https://github.com/apache/tinkerpop/pull/3195#discussion_r2329194399
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/binary/types/PSerializer.java:
##########
@@ -153,7 +154,14 @@ protected void writeValue(final T value, final Buffer
buffer, final GraphBinaryW
// the predicate name is either a static method of P or an instance
method when a type ConnectiveP
final boolean isConnectedP = value instanceof ConnectiveP;
final String predicateName = value.getPredicateName();
- final Object args = isConnectedP ? ((ConnectiveP<?>)
value).getPredicates() : value.getValue();
+ final Object args;
+ if (value instanceof ConnectiveP) {
Review Comment:
nit: variable `isConnectedP` can be used here or removed
> Simplify Comparability Semantics
> --------------------------------
>
> Key: TINKERPOP-3173
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3173
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.3
> Reporter: Cole Greer
> Priority: Major
>
> As recently discussed on the
> [devlist|https://lists.apache.org/thread/hsqw2tvc72dw4z40nnbbdmygrqx43syr],
> our current system of ternary boolean logic should be simplified to binary
> boolean logic where invalid comparisons simply return false.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
