[
https://issues.apache.org/jira/browse/TINKERPOP-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020467#comment-18020467
]
ASF GitHub Bot commented on TINKERPOP-3161:
-------------------------------------------
xiazcy commented on PR #3206:
URL: https://github.com/apache/tinkerpop/pull/3206#issuecomment-3294038179
> Is byte still used in this GLV or only sbyte now? If it's only byte then
you should remove functions like WriteByteAsync and serializers for byte.
For .NET GraphBinary it's used to serialize the type codes, etc., which I'm
not sure if they need all to be changed to sbyte
> Switched to signed bytes in .net
> --------------------------------
>
> Key: TINKERPOP-3161
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3161
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet
> Affects Versions: 3.7.3
> Reporter: Cole Greer
> Priority: Critical
> Labels: breaking
>
> The `Byte` type in our serializers represents a signed 8-bit integer (as this
> is what byte in Java represents), however this currently maps to `byte` in
> .net, which is an unsigned value. The .net serializers should be updated to
> use `sbyte` instead, to be consistent with the rest of TinkerPop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
