[ 
https://issues.apache.org/jira/browse/TINKERPOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18033920#comment-18033920
 ] 

ASF GitHub Bot commented on TINKERPOP-3202:
-------------------------------------------

codecov-commenter commented on PR #3255:
URL: https://github.com/apache/tinkerpop/pull/3255#issuecomment-3462814578

   ## 
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3255?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) 
report for BASE (`3.8-dev@0e7c2c6`). [Learn 
more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit)
 about missing BASE report.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             3.8-dev    #3255   +/-   ##
   ==========================================
     Coverage           ?   79.07%           
   ==========================================
     Files              ?       28           
     Lines              ?     5939           
     Branches           ?        0           
   ==========================================
     Hits               ?     4696           
     Misses             ?     1022           
     Partials           ?      221           
   ```
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3255?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Limit and range semantics change when used inside repeat
> --------------------------------------------------------
>
>                 Key: TINKERPOP-3202
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3202
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.7.4
>            Reporter: Andrea Child
>            Priority: Major
>              Labels: breaking
>             Fix For: 4.0.0, 3.8.0
>
>
> Original dev list post: 
> [https://lists.apache.org/thread/nclqpdb5d9wm6cgdxkk39k0co7gt564l]
> Currently, limit()​ and range()​ steps inside repeat()​ maintain global 
> counters that persist across repeat iterations, leading to strange behaviour. 
> To demonstrate, consider the following limit()​ traversals for the Grateful 
> Dead toy graph which are querying for pairs of song sequences starting with 
> the song 'JAM'.
> This repeat()​ traversal does not produce results because the limit(2)​ 
> counter reaches the global limit after the first iteration (note that 
> RepeatUnrollStrategy​ is disabled so that the repeat()​ step is not stripped 
> by strategy optimization):
> gremlin> 
> g.withoutStrategies(RepeatUnrollStrategy).V().has('name','JAM').repeat(out('followedBy').limit(2)).times(2).values('name’)​
> gremlin>​
> However, the following unrolled traversal without repeat()​ produces 2 
> results:
> gremlin> 
> g.V().has('name','JAM').out('followedBy').limit(2).out('followedBy').limit(2).propertyMap('name’)​
> ==>[name:[vp[name->HURTS ME TOO]]]​
> ==>[name:[vp[name->BLACK THROATED WIND]]]​
> These examples demonstrate how having globally tracked limit()​ and range()​ 
> counters inside repeat()​ are counter intuitive and instead should be tracked 
> per-iteration.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to